From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
"Markus Armbruster" <armbru@redhat.com>,
"Luiz Capitulino" <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 4/4] qapi: Add a primitive to include other files from a QAPI schema file
Date: Fri, 11 Apr 2014 12:03:40 -0600 [thread overview]
Message-ID: <53482E7C.20906@redhat.com> (raw)
In-Reply-To: <20140402151623.8123.80700.stgit@fimbulvetr.bsc.es>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On 04/02/2014 09:16 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
It would be worth mentioning the new syntax in the commit message
proper. True, reading qapi-code-gen.txt covers the details, but
repeating (or summarizing) it in the commit log means I don't have to
leave 'git log' just to learn the syntax.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-04-11 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 15:15 [Qemu-devel] [PATCH v8 0/4] qapi: Allow modularization of QAPI schema files Lluís Vilanova
2014-04-02 15:16 ` [Qemu-devel] [PATCH v8 1/4] qapi: [trivial] Break long command lines Lluís Vilanova
2014-04-11 15:42 ` Eric Blake
2014-04-02 15:16 ` [Qemu-devel] [PATCH v8 2/4] qapi: [trivial] Show full exception message in "test-qapi.py" Lluís Vilanova
2014-04-11 15:37 ` Markus Armbruster
2014-04-11 19:09 ` Lluís Vilanova
2014-04-02 15:16 ` [Qemu-devel] [PATCH v8 3/4] qapi: Use an explicit input file Lluís Vilanova
2014-04-11 15:57 ` Eric Blake
2014-04-02 15:16 ` [Qemu-devel] [PATCH v8 4/4] qapi: Add a primitive to include other files from a QAPI schema file Lluís Vilanova
2014-04-11 18:03 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53482E7C.20906@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.