From: Dave Hansen <dave.hansen@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
drepper@gmail.com, anatol.pomozov@gmail.com, jkosina@suse.cz,
akpm@linux-foundation.org, xemul@parallels.com,
paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] drivers/base/node.c: export physical address range of given node (Re: NUMA node information for pages)
Date: Fri, 11 Apr 2014 15:53:50 -0700 [thread overview]
Message-ID: <5348727E.3040308@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1404111513040.17724@chino.kir.corp.google.com>
On 04/11/2014 03:13 PM, David Rientjes wrote:
> What additional information, in your opinion, can we export to assist
> userspace in making this determination that $address is on $nid?
In the case of overlapping nodes, the only place we actually have *all*
of the information is in the 'struct page' itself. Ulrich's original
patch obviously _works_, and especially if it's an interface only for
debugging purposes, it seems silly to spend virtually any time
optimizing it. Keeping it close to pagemap's implementation lessens the
likelihood that we'll screw things up.
I assume that the original problem was trying to figure out what NUMA
affinity a given range of pages mapped in to a _process_ have, and that
/proc/$pid/numamaps is too coarse. Is that right, Ulrich?
If you want to go the route of calculating and exporting the physical
ranges that nodes uniquely own, you've *GOT* to handle the overlaps.
Naoya had the right idea. His idea seemed to get shot down with the
misunderstanding that node pfn ranges never overlap.
The only other question is how many of these kpage* things we're going
to put in here until we've exported the entire contents of 'struct page'
5 times over. :)
We could add some tracepoints to the pagemap to dump lots of information
in to a trace buffer that could be later read back. If you want
detailed information (NUMA for instance), you turn the tracepoints and
read pagemap for the range you care about.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
drepper@gmail.com, anatol.pomozov@gmail.com, jkosina@suse.cz,
akpm@linux-foundation.org, xemul@parallels.com,
paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] drivers/base/node.c: export physical address range of given node (Re: NUMA node information for pages)
Date: Fri, 11 Apr 2014 15:53:50 -0700 [thread overview]
Message-ID: <5348727E.3040308@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1404111513040.17724@chino.kir.corp.google.com>
On 04/11/2014 03:13 PM, David Rientjes wrote:
> What additional information, in your opinion, can we export to assist
> userspace in making this determination that $address is on $nid?
In the case of overlapping nodes, the only place we actually have *all*
of the information is in the 'struct page' itself. Ulrich's original
patch obviously _works_, and especially if it's an interface only for
debugging purposes, it seems silly to spend virtually any time
optimizing it. Keeping it close to pagemap's implementation lessens the
likelihood that we'll screw things up.
I assume that the original problem was trying to figure out what NUMA
affinity a given range of pages mapped in to a _process_ have, and that
/proc/$pid/numamaps is too coarse. Is that right, Ulrich?
If you want to go the route of calculating and exporting the physical
ranges that nodes uniquely own, you've *GOT* to handle the overlaps.
Naoya had the right idea. His idea seemed to get shot down with the
misunderstanding that node pfn ranges never overlap.
The only other question is how many of these kpage* things we're going
to put in here until we've exported the entire contents of 'struct page'
5 times over. :)
We could add some tracepoints to the pagemap to dump lots of information
in to a trace buffer that could be later read back. If you want
detailed information (NUMA for instance), you turn the tracepoints and
read pagemap for the range you care about.
next prev parent reply other threads:[~2014-04-11 22:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 23:41 NUMA node information for pages Ulrich Drepper
[not found] ` <533a1566.540db40a.274d.ffff8616SMTPIN_ADDED_BROKEN@mx.google.com>
2014-04-01 4:28 ` David Rientjes
[not found] ` <533a1563.ad318c0a.6a93.182bSMTPIN_ADDED_BROKEN@mx.google.com>
2014-04-08 1:56 ` Ulrich Drepper
[not found] ` <5343806c.100cc30a.0461.ffffc401SMTPIN_ADDED_BROKEN@mx.google.com>
2014-04-10 0:41 ` David Rientjes
[not found] ` <5345fe27.82dab40a.0831.0af9SMTPIN_ADDED_BROKEN@mx.google.com>
2014-04-10 22:06 ` David Rientjes
2014-04-11 1:35 ` [PATCH] drivers/base/node.c: export physical address range of given node (Re: NUMA node information for pages) Naoya Horiguchi
2014-04-11 3:03 ` Naoya Horiguchi
[not found] ` <53474709.e59ec20a.3bd5.3b91SMTPIN_ADDED_BROKEN@mx.google.com>
2014-04-11 11:00 ` David Rientjes
2014-04-11 11:00 ` David Rientjes
2014-04-11 11:43 ` Naoya Horiguchi
2014-04-11 16:24 ` Dave Hansen
2014-04-11 16:24 ` Dave Hansen
2014-04-11 22:13 ` David Rientjes
2014-04-11 22:13 ` David Rientjes
2014-04-11 22:53 ` Dave Hansen [this message]
2014-04-11 22:53 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5348727E.3040308@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anatol.pomozov@gmail.com \
--cc=drepper@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.