Re: [osd-dev] [PATCH 1/3] ore: (trivial) reformat some code

[Boaz Harrosh <bharrosh@panasas.com>]

On 04/12/2014 12:07 PM, Boaz Harrosh wrote:
>>> -			ret = _ore_add_parity_unit(ios, si, per_dev, cur_len);
>>> +			/* In writes cur_len just means if it's the
>>> +			 * last one. See _ore_add_parity_unit.
>>> +			 */
>>> +			ret = _ore_add_parity_unit(ios, si, per_dev,
>>> +						   ios->sp2d : length : cur_len);
>>
>> Hi Boaz, 
>>
>> did you meant
>>  
>>      ios->sp2d ? length : cur_len);
> 
> my god yes!! why doe it compile? 
> 
> Thanks man
> Boaz
> 

OK Now I know. This same line changes again in the last patch and there
it is correct. I have only always tested the 3 together so it never showed
up. I'll fix it for the next round

Thanks for the catch, you saved me. Beers on me next time
Boaz