From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Bandan Das <bsd@redhat.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 2/3] KVM: nVMX: Ack and write vector info to intr_info if L1 asks us to
Date: Sat, 12 Apr 2014 12:57:01 -0400 [thread overview]
Message-ID: <5349705D.7030603@redhat.com> (raw)
In-Reply-To: <20140411192007.GA19778@amt.cnet>
Il 11/04/2014 15:20, Marcelo Tosatti ha scritto:
>>> > >
>>> > > Can irq be -1 ?
>> >
>> > If it is, I think that's a bug because if we exited for this
>> > reason with INTR_ACK set, the hypervisor expects a valid vector
>> > number to be available.
>> >
>> > What about adding a BUG_ON ?
> Sounds good.
Each BUG_ON we add to KVM is a potential guest-kill-host vulnerability.
WARN_ON is better.
Paolo
next prev parent reply other threads:[~2014-04-12 16:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:00 [PATCH v2 0/3] nVMX: Fixes to run Xen as L1 Bandan Das
2014-03-31 21:00 ` [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept Bandan Das
2014-04-10 20:47 ` Marcelo Tosatti
2014-04-11 0:27 ` Bandan Das
2014-04-11 6:22 ` Jan Kiszka
2014-04-11 17:26 ` Bandan Das
2014-04-11 18:01 ` Jan Kiszka
2014-04-11 18:35 ` Bandan Das
2014-04-11 18:53 ` Jan Kiszka
2014-04-11 19:35 ` Marcelo Tosatti
2014-04-14 5:46 ` Jan Kiszka
2014-04-11 19:38 ` Bandan Das
2014-04-11 18:48 ` Marcelo Tosatti
2014-04-11 19:33 ` Bandan Das
2014-04-11 19:02 ` Marcelo Tosatti
2014-03-31 21:00 ` [PATCH v2 2/3] KVM: nVMX: Ack and write vector info to intr_info if L1 asks us to Bandan Das
2014-04-11 18:33 ` Marcelo Tosatti
2014-04-11 19:17 ` Bandan Das
2014-04-11 19:20 ` Marcelo Tosatti
2014-04-12 16:57 ` Paolo Bonzini [this message]
2014-03-31 21:00 ` [PATCH v2 3/3] KVM: nVMX: Advertise support for interrupt acknowledgement Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5349705D.7030603@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.