From: Jonathan Cameron <jic23@kernel.org>
To: Michael Welling <mwelling@ieee.org>,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/3] Staging: iio: Remove quoted string split across lines warnings
Date: Sat, 12 Apr 2014 18:31:36 +0100 [thread overview]
Message-ID: <53497878.9040208@kernel.org> (raw)
In-Reply-To: <1397096805-25168-3-git-send-email-mwelling@ieee.org>
On 10/04/14 03:26, Michael Welling wrote:
> Signed-off-by: Michael Welling <mwelling@ieee.org>
Applied to the togreg branch of iio.git - initially pushed out as testing.
Thanks,
> ---
> drivers/staging/iio/light/tsl2583.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 77c7f65..f015fb4 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -165,8 +165,9 @@ taos_i2c_read(struct i2c_client *client, u8 reg, u8 *val, unsigned int len)
> /* select register to write */
> ret = i2c_smbus_write_byte(client, (TSL258X_CMD_REG | reg));
> if (ret < 0) {
> - dev_err(&client->dev, "taos_i2c_read failed to write"
> - " register %x\n", reg);
> + dev_err(&client->dev,
> + "taos_i2c_read failed to write register %x\n",
> + reg);
> return ret;
> }
> /* read the data */
> @@ -231,8 +232,9 @@ static int taos_get_lux(struct iio_dev *indio_dev)
> int reg = TSL258X_CMD_REG | (TSL258X_ALS_CHAN0LO + i);
> ret = taos_i2c_read(chip->client, reg, &buf[i], 1);
> if (ret < 0) {
> - dev_err(&chip->client->dev, "taos_get_lux failed to read"
> - " register %x\n", reg);
> + dev_err(&chip->client->dev,
> + "taos_get_lux failed to read register %x\n",
> + reg);
> goto out_unlock;
> }
> }
> @@ -809,9 +811,7 @@ static int taos_probe(struct i2c_client *clientp,
>
> if (!i2c_check_functionality(clientp->adapter,
> I2C_FUNC_SMBUS_BYTE_DATA)) {
> - dev_err(&clientp->dev,
> - "taos_probe() - i2c smbus byte data "
> - "functions unsupported\n");
> + dev_err(&clientp->dev, "taos_probe() - i2c smbus byte data func unsupported\n");
> return -EOPNOTSUPP;
> }
>
> @@ -830,30 +830,32 @@ static int taos_probe(struct i2c_client *clientp,
> ret = i2c_smbus_write_byte(clientp,
> (TSL258X_CMD_REG | (TSL258X_CNTRL + i)));
> if (ret < 0) {
> - dev_err(&clientp->dev, "i2c_smbus_write_bytes() to cmd "
> - "reg failed in taos_probe(), err = %d\n", ret);
> + dev_err(&clientp->dev,
> + "i2c_smbus_write_byte to cmd reg failed in taos_probe(), err = %d\n",
> + ret);
> return ret;
> }
> ret = i2c_smbus_read_byte(clientp);
> if (ret < 0) {
> - dev_err(&clientp->dev, "i2c_smbus_read_byte from "
> - "reg failed in taos_probe(), err = %d\n", ret);
> -
> + dev_err(&clientp->dev,
> + "i2c_smbus_read_byte from reg failed in taos_probe(), err = %d\n",
> + ret);
> return ret;
> }
> buf[i] = ret;
> }
>
> if (!taos_tsl258x_device(buf)) {
> - dev_info(&clientp->dev, "i2c device found but does not match "
> - "expected id in taos_probe()\n");
> + dev_info(&clientp->dev,
> + "i2c device found but does not match expected id in taos_probe()\n");
> return -EINVAL;
> }
>
> ret = i2c_smbus_write_byte(clientp, (TSL258X_CMD_REG | TSL258X_CNTRL));
> if (ret < 0) {
> - dev_err(&clientp->dev, "i2c_smbus_write_byte() to cmd reg "
> - "failed in taos_probe(), err = %d\n", ret);
> + dev_err(&clientp->dev,
> + "i2c_smbus_write_byte() to cmd reg failed in taos_probe(), err = %d\n",
> + ret);
> return ret;
> }
>
>
next prev parent reply other threads:[~2014-04-12 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 2:26 [PATCH 0/3] Staging: iio: tsl2583 checkpatch fixes Michael Welling
2014-04-10 2:26 ` [PATCH 1/3] Staging: iio: Removes unwanted space before semicolon Michael Welling
2014-04-12 17:30 ` Jonathan Cameron
2014-04-10 2:26 ` [PATCH 2/3] Staging: iio: Remove quoted string split across lines warnings Michael Welling
2014-04-12 17:31 ` Jonathan Cameron [this message]
2014-04-10 2:26 ` [PATCH 3/3] Staging: iio: Switch from msleep to usleep range per timers-howto.txt Michael Welling
2014-04-12 17:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53497878.9040208@kernel.org \
--to=jic23@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.