From: Kinglong Mee <kinglongmee@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org
Subject: [PATCH] NFSD: Checking whether kill_suid by should_remove_suid()
Date: Sun, 13 Apr 2014 23:11:39 +0800 [thread overview]
Message-ID: <534AA92B.8010805@gmail.com> (raw)
As local filesystem, writing data to the file by non-owner will
clears the SUID+SGID, owner will not.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/vfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 16f0673..19c0931 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -943,7 +943,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh
*fhp, struct file *file,
fsnotify_modify(file);
/* clear setuid/setgid flag after write */
- if (inode->i_mode & (S_ISUID | S_ISGID))
+ if (should_remove_suid(dentry))
kill_suid(dentry);
if (stable) {
--
1.9.0
next reply other threads:[~2014-04-13 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 15:11 Kinglong Mee [this message]
2014-04-18 13:02 ` [PATCH] NFSD: Checking whether kill_suid by should_remove_suid() J. Bruce Fields
2014-04-18 13:51 ` Kinglong Mee
2014-04-18 16:17 ` [PATCH v2] NFSD: Don't clear SUID/SGID after root writing data Kinglong Mee
2014-05-08 16:12 ` J. Bruce Fields
2014-05-09 7:55 ` Kinglong Mee
2014-05-09 21:40 ` J. Bruce Fields
2014-05-10 5:10 ` Christoph Hellwig
2014-05-16 7:31 ` Kinglong Mee
2014-05-16 15:12 ` Christoph Hellwig
2014-04-18 16:25 ` [PATCH] NFSD: Checking whether kill_suid by should_remove_suid() Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534AA92B.8010805@gmail.com \
--to=kinglongmee@gmail.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.