From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge Date: Mon, 14 Apr 2014 09:48:15 +0800 Message-ID: <534B3E5F.3090609@cn.fujitsu.com> References: <5347BAA5.6070104@cn.fujitsu.com> <534B374C.8030009@cn.fujitsu.com> <1397439855.24638.24.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WZW9n-0006P8-Vl for linux-f2fs-devel@lists.sourceforge.net; Mon, 14 Apr 2014 01:58:00 +0000 Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1WZW9m-0000rM-El for linux-f2fs-devel@lists.sourceforge.net; Mon, 14 Apr 2014 01:57:59 +0000 In-Reply-To: <1397439855.24638.24.camel@kjgkr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: jaegeuk.kim@samsung.com Cc: fsdevel , linux-kernel , f2fs T24gMDQvMTQvMjAxNCAwOTo0NCBBTSwgSmFlZ2V1ayBLaW0gd3JvdGU6Cgo+IEhpIEd1LAo+IAo+ IEkganVzdCBzdGFydGVkIHRvIHJldmlldyB0aGUgcGF0Y2hlcyBhbmQgbWVyZ2UgdGhlbSBpbmRp dmlkdWFsbHkgdGhvdWdoLgo+IFNpbmNlIEkndmUgYmVlbiBpbnRlcm5hbGx5IGRvaW5nIGluIG15 IGxvY2FsIHRyZWUsIHNvIHRoYXQgc2hvdWxkIGJlIG5vCj4gcHJvYmxlbS4gSSdsbCByb2xsIGJh Y2sgdG8gdGhlIGxhdGVzdCBwb2ludC4KCk9LLCBhbmQgcGxlYXNlIHBheSBzb21lIGF0dGVudGlv biB0byB0aGUgZmx1c2ggY21kcyBtZXJnaW5nIG9wZXJhdGlvbiB3aGVuIGRvaW5nCnRlc3RzLCBp dCBzZWVtcyB0aGF0IHNvbWUgb2YgdGhlIG91dHN0YW5kaW5nIGZsdXNoIGNtZHMoaW4gdGhlIGlz c3VlX2xpc3QpIHdpbGwKYmUgaWdub3JlZCB3aGVuIG5ldyBjbWQgYWRkZWQuCkknbGwgcmV2aWV3 IGFuZCB0ZXN0IGl0IG1vcmUuCgo+IEFueXdheSwgdGhhbmsgeW91IGZvciB5b3VyIHdvcmsuIDop CgoKUmVnYXJkcywKR3UKCj4gCj4gMjAxNC0wNC0xNCAo7JuUKSwgMDk6MTggKzA4MDAsIEd1IFpo ZW5nOgo+PiBIaSBBbGwsCj4+IFRoZXJlIHNlZW1zIHRvIGJlIGEgbWlzdGFrZSBpbiAiW1BBVENI IDIvN11mMmZzOiByZW1vdmUgdGhlIHVudXNlZnVsICJpc3N1ZV90YWlsIiBsaXN0IiwKPj4gYW5k IHRoZSB3aG9sZSBwYXRjaHNldCBuZWVkcyB0byBiZSByZXdvcmtlZC4gU28gcGxlYXNlIGlnbm9y ZSB0aGlzIG9uZS4KPj4gU29ycnkgZm9yIHRoZSBub2lzZS4KPj4KPj4gUmVnYXJkcywKPj4gR3UK Pj4gT24gMDQvMTEvMjAxNCAwNTo0OSBQTSwgR3UgWmhlbmcgd3JvdGU6Cj4+Cj4+PiBHdSBaaGVu ZyAoNyk6Cj4+PiAgIGYyZnM6IHB1dCB0aGUgYmlvIHdoZW4gaXNzdWVfZmx1c2ggY29tcGxldGVk Cj4+PiAgIGYyZnM6IHJlbW92ZSB0aGUgdW51c2VmdWwgImlzc3VlX3RhaWwiIGxpc3QKPj4+ICAg ZjJmczogdXNlIF9fR0ZQX1pFUk8gdG8gYXZvaWQgYXBwZW5kaW5nIHNldC1OVUxMCj4+PiAgIGYy ZnM6IGVuYWJsZSBmbHVzaF9tZXJnZSBvbmx5IGluIGYyZnMgaXMgbm90IHJlYWQtb25seQo+Pj4g ICBmMmZzOiBhZGQgdGhlIGZsdXNoX21lcmdlIGhhbmRsZSBpbiB0aGUgcmVtb3VudCBmbG93Cj4+ PiAgIGYyZnM6IGludHJvZHVjZSBzdHJ1Y3QgZmx1c2hfY21kX2NvbnRyb2wgdG8gd3JhcCB0aGUg Zmx1c2hfbWVyZ2UKPj4+ICAgICBmaWVsZHMKPj4+ICAgZjJmczogaW50cm9kdWNlIGhlbHAgZnVu Y3Rpb24ge2NyZWF0ZSxkZXN0cm95fV9mbHVzaF9jbWRfY29udHJvbAo+Pj4KPj4+ICBmcy9mMmZz L2YyZnMuaCAgICB8ICAgMTcgKysrKysrLS0tCj4+PiAgZnMvZjJmcy9zZWdtZW50LmMgfCAgMTAy ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPj4+ ICBmcy9mMmZzL3N1cGVyLmMgICB8ICAgMzIgKysrKysrKysrKysrKystLQo+Pj4gIDMgZmlsZXMg Y2hhbmdlZCwgMTA3IGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQo+Pj4KPj4KPj4KPj4g LS0KPj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGxpbnV4LWZzZGV2ZWwiIGluCj4+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92 Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IAoKCgotLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KTGVhcm4gR3JhcGggRGF0YWJhc2VzIC0gRG93bmxvYWQgRlJFRSBPJ1JlaWxseSBCb29r CiJHcmFwaCBEYXRhYmFzZXMiIGlzIHRoZSBkZWZpbml0aXZlIG5ldyBndWlkZSB0byBncmFwaCBk YXRhYmFzZXMgYW5kIHRoZWlyCmFwcGxpY2F0aW9ucy4gV3JpdHRlbiBieSB0aHJlZSBhY2NsYWlt ZWQgbGVhZGVycyBpbiB0aGUgZmllbGQsCnRoaXMgZmlyc3QgZWRpdGlvbiBpcyBub3cgYXZhaWxh YmxlLiBEb3dubG9hZCB5b3VyIGZyZWUgYm9vayB0b2RheSEKaHR0cDovL3Auc2YubmV0L3NmdS9O ZW9UZWNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNl Zm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xp bnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge Date: Mon, 14 Apr 2014 09:48:15 +0800 Message-ID: <534B3E5F.3090609@cn.fujitsu.com> References: <5347BAA5.6070104@cn.fujitsu.com> <534B374C.8030009@cn.fujitsu.com> <1397439855.24638.24.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: fsdevel , linux-kernel , f2fs To: Return-path: In-Reply-To: <1397439855.24638.24.camel@kjgkr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org T24gMDQvMTQvMjAxNCAwOTo0NCBBTSwgSmFlZ2V1ayBLaW0gd3JvdGU6Cgo+IEhpIEd1LAo+IAo+ IEkganVzdCBzdGFydGVkIHRvIHJldmlldyB0aGUgcGF0Y2hlcyBhbmQgbWVyZ2UgdGhlbSBpbmRp dmlkdWFsbHkgdGhvdWdoLgo+IFNpbmNlIEkndmUgYmVlbiBpbnRlcm5hbGx5IGRvaW5nIGluIG15 IGxvY2FsIHRyZWUsIHNvIHRoYXQgc2hvdWxkIGJlIG5vCj4gcHJvYmxlbS4gSSdsbCByb2xsIGJh Y2sgdG8gdGhlIGxhdGVzdCBwb2ludC4KCk9LLCBhbmQgcGxlYXNlIHBheSBzb21lIGF0dGVudGlv biB0byB0aGUgZmx1c2ggY21kcyBtZXJnaW5nIG9wZXJhdGlvbiB3aGVuIGRvaW5nCnRlc3RzLCBp dCBzZWVtcyB0aGF0IHNvbWUgb2YgdGhlIG91dHN0YW5kaW5nIGZsdXNoIGNtZHMoaW4gdGhlIGlz c3VlX2xpc3QpIHdpbGwKYmUgaWdub3JlZCB3aGVuIG5ldyBjbWQgYWRkZWQuCkknbGwgcmV2aWV3 IGFuZCB0ZXN0IGl0IG1vcmUuCgo+IEFueXdheSwgdGhhbmsgeW91IGZvciB5b3VyIHdvcmsuIDop CgoKUmVnYXJkcywKR3UKCj4gCj4gMjAxNC0wNC0xNCAo7JuUKSwgMDk6MTggKzA4MDAsIEd1IFpo ZW5nOgo+PiBIaSBBbGwsCj4+IFRoZXJlIHNlZW1zIHRvIGJlIGEgbWlzdGFrZSBpbiAiW1BBVENI IDIvN11mMmZzOiByZW1vdmUgdGhlIHVudXNlZnVsICJpc3N1ZV90YWlsIiBsaXN0IiwKPj4gYW5k IHRoZSB3aG9sZSBwYXRjaHNldCBuZWVkcyB0byBiZSByZXdvcmtlZC4gU28gcGxlYXNlIGlnbm9y ZSB0aGlzIG9uZS4KPj4gU29ycnkgZm9yIHRoZSBub2lzZS4KPj4KPj4gUmVnYXJkcywKPj4gR3UK Pj4gT24gMDQvMTEvMjAxNCAwNTo0OSBQTSwgR3UgWmhlbmcgd3JvdGU6Cj4+Cj4+PiBHdSBaaGVu ZyAoNyk6Cj4+PiAgIGYyZnM6IHB1dCB0aGUgYmlvIHdoZW4gaXNzdWVfZmx1c2ggY29tcGxldGVk Cj4+PiAgIGYyZnM6IHJlbW92ZSB0aGUgdW51c2VmdWwgImlzc3VlX3RhaWwiIGxpc3QKPj4+ICAg ZjJmczogdXNlIF9fR0ZQX1pFUk8gdG8gYXZvaWQgYXBwZW5kaW5nIHNldC1OVUxMCj4+PiAgIGYy ZnM6IGVuYWJsZSBmbHVzaF9tZXJnZSBvbmx5IGluIGYyZnMgaXMgbm90IHJlYWQtb25seQo+Pj4g ICBmMmZzOiBhZGQgdGhlIGZsdXNoX21lcmdlIGhhbmRsZSBpbiB0aGUgcmVtb3VudCBmbG93Cj4+ PiAgIGYyZnM6IGludHJvZHVjZSBzdHJ1Y3QgZmx1c2hfY21kX2NvbnRyb2wgdG8gd3JhcCB0aGUg Zmx1c2hfbWVyZ2UKPj4+ICAgICBmaWVsZHMKPj4+ICAgZjJmczogaW50cm9kdWNlIGhlbHAgZnVu Y3Rpb24ge2NyZWF0ZSxkZXN0cm95fV9mbHVzaF9jbWRfY29udHJvbAo+Pj4KPj4+ICBmcy9mMmZz L2YyZnMuaCAgICB8ICAgMTcgKysrKysrLS0tCj4+PiAgZnMvZjJmcy9zZWdtZW50LmMgfCAgMTAy ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPj4+ ICBmcy9mMmZzL3N1cGVyLmMgICB8ICAgMzIgKysrKysrKysrKysrKystLQo+Pj4gIDMgZmlsZXMg Y2hhbmdlZCwgMTA3IGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQo+Pj4KPj4KPj4KPj4g LS0KPj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGxpbnV4LWZzZGV2ZWwiIGluCj4+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92 Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IAoKCgotLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KTGVhcm4gR3JhcGggRGF0YWJhc2VzIC0gRG93bmxvYWQgRlJFRSBPJ1JlaWxseSBCb29r CiJHcmFwaCBEYXRhYmFzZXMiIGlzIHRoZSBkZWZpbml0aXZlIG5ldyBndWlkZSB0byBncmFwaCBk YXRhYmFzZXMgYW5kIHRoZWlyCmFwcGxpY2F0aW9ucy4gV3JpdHRlbiBieSB0aHJlZSBhY2NsYWlt ZWQgbGVhZGVycyBpbiB0aGUgZmllbGQsCnRoaXMgZmlyc3QgZWRpdGlvbiBpcyBub3cgYXZhaWxh YmxlLiBEb3dubG9hZCB5b3VyIGZyZWUgYm9vayB0b2RheSEKaHR0cDovL3Auc2YubmV0L3NmdS9O ZW9UZWNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNl Zm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xp bnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbaDNB6B (ORCPT ); Sun, 13 Apr 2014 21:58:01 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:34136 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754721AbaDNB56 convert rfc822-to-8bit (ORCPT ); Sun, 13 Apr 2014 21:57:58 -0400 X-IronPort-AV: E=Sophos;i="4.97,853,1389715200"; d="scan'208";a="29208433" Message-ID: <534B3E5F.3090609@cn.fujitsu.com> Date: Mon, 14 Apr 2014 09:48:15 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: CC: f2fs , fsdevel , linux-kernel Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge References: <5347BAA5.6070104@cn.fujitsu.com> <534B374C.8030009@cn.fujitsu.com> <1397439855.24638.24.camel@kjgkr> In-Reply-To: <1397439855.24638.24.camel@kjgkr> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.167.226.100] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2014 09:44 AM, Jaegeuk Kim wrote: > Hi Gu, > > I just started to review the patches and merge them individually though. > Since I've been internally doing in my local tree, so that should be no > problem. I'll roll back to the latest point. OK, and please pay some attention to the flush cmds merging operation when doing tests, it seems that some of the outstanding flush cmds(in the issue_list) will be ignored when new cmd added. I'll review and test it more. > Anyway, thank you for your work. :) Regards, Gu > > 2014-04-14 (월), 09:18 +0800, Gu Zheng: >> Hi All, >> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list", >> and the whole patchset needs to be reworked. So please ignore this one. >> Sorry for the noise. >> >> Regards, >> Gu >> On 04/11/2014 05:49 PM, Gu Zheng wrote: >> >>> Gu Zheng (7): >>> f2fs: put the bio when issue_flush completed >>> f2fs: remove the unuseful "issue_tail" list >>> f2fs: use __GFP_ZERO to avoid appending set-NULL >>> f2fs: enable flush_merge only in f2fs is not read-only >>> f2fs: add the flush_merge handle in the remount flow >>> f2fs: introduce struct flush_cmd_control to wrap the flush_merge >>> fields >>> f2fs: introduce help function {create,destroy}_flush_cmd_control >>> >>> fs/f2fs/f2fs.h | 17 ++++++--- >>> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++----------------- >>> fs/f2fs/super.c | 32 ++++++++++++++-- >>> 3 files changed, 107 insertions(+), 44 deletions(-) >>> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >