From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: Balakumaran Kannan <kumaran.4353@gmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
kaber@trash.net, netdev@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] net IPv6: Remove unnecessary argument of ndisc_send_ns and ndisc_send_na
Date: Mon, 14 Apr 2014 14:13:18 +0900 [thread overview]
Message-ID: <534B6E6E.5020104@linux-ipv6.org> (raw)
In-Reply-To: <534B58AA.80704@gmail.com>
Balakumaran Kannan wrote:
> The 'neigh' argument of 'ndisc_send_ns' and 'ndisc_send_na' are not used in
> these functions. So this could be removed.
>
> And a minor change of 'optlen' assignment in those functions. the compound
> addition and assignment operator is not needed as 'optlen' value is always
> zero.
Do not mix changes.
Well, it is for future extension so that we can prepend another option
easier. Do you see any penalty here?
>
> Signed-off-by: Balakumaran Kannan <kumaran.4353@gmail.com>
> ---
> I am not sure whether 'neigh' argument is intentional or planned for any
> future use. If you find this is unnecessary, this patch could be considered.
>
> And ndisc_send_na is used as a function pointer in ipv6_stub. This may affect anybody
> using this structure. But with default configuration built, I didn't get any error or
> warning. Kindly consider this scenario also.
drivers/net/usb/cdc_mbim.c uses it at least.
--yoshfuji
prev parent reply other threads:[~2014-04-14 5:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 3:40 [PATCH] net IPv6: Remove unnecessary argument of ndisc_send_ns and ndisc_send_na Balakumaran Kannan
2014-04-14 5:13 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534B6E6E.5020104@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kumaran.4353@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.