From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 01/18] drm/omap: fix up pdev_remove Date: Mon, 14 Apr 2014 09:26:14 +0300 Message-ID: <534B7F86.1040104@ti.com> References: <1397252175-14227-1-git-send-email-daniel.vetter@ffwll.ch> <1397252175-14227-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1542036281==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTP id 7141E6E6DA for ; Sun, 13 Apr 2014 23:26:18 -0700 (PDT) In-Reply-To: <1397252175-14227-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Dave Airlie List-Id: dri-devel@lists.freedesktop.org --===============1542036281== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SvwB9XFV32FlkLw6aDR3U42MliLWH5kCW" --SvwB9XFV32FlkLw6aDR3U42MliLWH5kCW Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, On 12/04/14 00:35, Daniel Vetter wrote: > Dave accidentally merged the wrong version of the patch in >=20 > commit fd3c02531461924853db65f2664db361b53a70d3 > Author: Daniel Vetter > Date: Wed Dec 11 11:34:26 2013 +0100 >=20 > drm/omap: call drm_put_dev directly in ->remove >=20 > which did not include the fix from Rob's review: omapdrm is split into > the drm driver and the dmm driver (yeah, I've complained about that > almost-impossible-to-spot difference, too). We need to unregister the > dmm driver in the pdev_remove hook. >=20 > Cc: Dave Airlie > Cc: Rob Clark > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapd= rm/omap_drv.c > index bf39fcc49e0f..89557989737d 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -699,6 +699,8 @@ static int pdev_remove(struct platform_device *devi= ce) > omap_disconnect_dssdevs(); > omap_crtc_pre_uninit(); > =20 > + platform_driver_unregister(&omap_dmm_driver); > + > drm_put_dev(platform_get_drvdata(device)); > return 0; > } Your patch does fix the "drm/omap: call drm_put_dev directly in ->remove" patch, but I think the unregistering is not right if done in pdev_remove. I sent this patch a few weeks ago: http://www.spinics.net/lists/dri-devel/msg56464.html It unregisters the dmm driver at the module exit function, which is the proper place for it as the dmm driver is registered in the module init function. Tomi --SvwB9XFV32FlkLw6aDR3U42MliLWH5kCW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJTS3+GAAoJEPo9qoy8lh71uFsQAJbw7NBoe4p5HvbJjv4SyJMo Xjug6W497v7vN7pI/8bwgBCtgFpAsdNztrXhJGb9ZBiq2ai48NEkGNG8jO4arO0W +CWwKqgBXDEGuRBUu3sPXPD0VNn6hUkKXunXJWG0fZSCgI6fI5RAWcTn+4l9ObEQ sRBJfTOWM+LRFsRFvnvTza13Dh7ZA5mJVd2TRK+UQCqn+45lsS7QoG0pgl4FWJvH jLYvoWklqEjdMpfL9WUOYcpv+TF/U0vnVoTXhH1RhqRKA6WKVw+AQb/sTxU1M2tD 8RmzJMAT+AZhq/9rjN5Y+8UnQRz0xu0JeqtgIdt0GPfKRc15eKMoZ0wR2IYW6fEq lshb9lUnN/PxW2COhAVyTrbMi5bZKscAUsMUeqSfClIy52hF++882KbeTLJaU129 N7SW9kSa/3K+dBo41RtBwdu6htTNB/45u4s9+51SHm1hXnnjKrlUhz6xkHQvv2Z3 GtEe1H+De8OevyAdTm1m4A2xiaSm9J5DSTj5riD5VoPMQcVlnBWoBRsfJhNvqAZX d/aas/sLhbMDlpT7PbZRts44Je8Ionckn/Ana2d0dM3k0ZeJQoM9OmQurUiycN6T /yZSJhvBlj7WYIgvgxa+4y01ctRobbskSxl36wPTIaprxwyEhRfbKucKP9OhCOlH BK6WHxC6ZVM9+7tvL8ox =m+7t -----END PGP SIGNATURE----- --SvwB9XFV32FlkLw6aDR3U42MliLWH5kCW-- --===============1542036281== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1542036281==--