From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: commit b3a977b224 {ARM: Better virt_to_page() handling} breaks Keystone boot
Date: Mon, 14 Apr 2014 09:36:47 -0400 [thread overview]
Message-ID: <534BE46F.2070201@ti.com> (raw)
In-Reply-To: <20140412084630.GT16119@n2100.arm.linux.org.uk>
On Saturday 12 April 2014 04:46 AM, Russell King - ARM Linux wrote:
> On Fri, Apr 11, 2014 at 09:16:40PM -0400, Santosh Shilimkar wrote:
>> + if (mem_start < KEYSTONE_HIGH_PHYS_START ||
>> + mem_end > KEYSTONE_HIGH_PHYS_END) {
>> + pr_crit("Invalid address space for memory (%08llx-%08llx)\n",
>> + (u64)mem_start, (u64)mem_end);
>> + }
>> +
>> + offset += KEYSTONE_HIGH_PHYS_START;
>> + __pv_phys_offset = offset;
>
> Right, so this will create a link error, and needs to become:
>
Yep and I did fix that by using __pv_phys_pfn_offset
> __pv_phys_pfn_offset = offset >> PAGE_SHIFT;
>
But I missed to convert it to pfn and that was the issue.
Thanks.
Regards,
Santosh
prev parent reply other threads:[~2014-04-14 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 23:28 commit b3a977b224 {ARM: Better virt_to_page() handling} breaks Keystone boot Santosh Shilimkar
2014-04-12 0:13 ` Nicolas Pitre
2014-04-12 0:24 ` Russell King - ARM Linux
2014-04-12 0:38 ` Nicolas Pitre
2014-04-12 1:16 ` Santosh Shilimkar
2014-04-12 8:46 ` Russell King - ARM Linux
2014-04-14 13:36 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534BE46F.2070201@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.