From: Marc Zyngier <marc.zyngier@arm.com>
To: Jungseok Lee <jays.lee@samsung.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"sungjinn.chung@samsung.com" <sungjinn.chung@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"ilho215.lee@samsung.com" <ilho215.lee@samsung.com>
Subject: Re: [PATCH 2/8] arm/arm64: KVM: Fix line length exceeding 80 characters
Date: Mon, 14 Apr 2014 17:19:21 +0100 [thread overview]
Message-ID: <534C0A89.4090907@arm.com> (raw)
In-Reply-To: <000001cf57b4$d3450780$79cf1680$@samsung.com>
On 14/04/14 08:40, Jungseok Lee wrote:
> This patch deals with checkpatch complaint as fixing line length
> exceeding 80 characters.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Jungseok Lee <jays.lee@samsung.com>
> Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com>
> ---
> arch/arm/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index 80bb1e6..e0d4f24 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm)
> kvm->arch.pgd = NULL;
> }
>
> -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache,
> - phys_addr_t addr)
> +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache
> + *cache, phys_addr_t addr)
Please don't. This makes the code unreadable (and no, I don't care about
checkpatch ;-).
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] arm/arm64: KVM: Fix line length exceeding 80 characters
Date: Mon, 14 Apr 2014 17:19:21 +0100 [thread overview]
Message-ID: <534C0A89.4090907@arm.com> (raw)
In-Reply-To: <000001cf57b4$d3450780$79cf1680$@samsung.com>
On 14/04/14 08:40, Jungseok Lee wrote:
> This patch deals with checkpatch complaint as fixing line length
> exceeding 80 characters.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Jungseok Lee <jays.lee@samsung.com>
> Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com>
> ---
> arch/arm/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index 80bb1e6..e0d4f24 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm)
> kvm->arch.pgd = NULL;
> }
>
> -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache,
> - phys_addr_t addr)
> +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache
> + *cache, phys_addr_t addr)
Please don't. This makes the code unreadable (and no, I don't care about
checkpatch ;-).
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-04-14 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 7:40 [PATCH 2/8] arm/arm64: KVM: Fix line length exceeding 80 characters Jungseok Lee
2014-04-14 7:40 ` Jungseok Lee
2014-04-14 16:19 ` Marc Zyngier [this message]
2014-04-14 16:19 ` Marc Zyngier
2014-04-15 0:38 ` Jungseok Lee
2014-04-15 0:38 ` Jungseok Lee
2014-04-15 8:11 ` Marc Zyngier
2014-04-15 8:11 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C0A89.4090907@arm.com \
--to=marc.zyngier@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=arnd@arndb.de \
--cc=christoffer.dall@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=jays.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sungjinn.chung@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.