From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v2 02/10] hvm/hpet: Only call guest_time_hpet(h) one time per action. Date: Mon, 14 Apr 2014 13:38:22 -0400 Message-ID: <534C1D0E.7030402@terremark.com> References: <1396967094-29484-1-git-send-email-dslutz@verizon.com> <1396967094-29484-3-git-send-email-dslutz@verizon.com> <534C0D710200007800008844@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534C0D710200007800008844@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Don Slutz Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/14/14 10:31, Jan Beulich wrote: >>>> On 08.04.14 at 16:24, wrote: > This looks good to me, just a minor comment: > >> -static void hpet_set_timer(HPETState *h, unsigned int tn) >> +static void hpet_set_timer(HPETState *h, unsigned int tn, int mc_starting) > This as well as ... > >> @@ -283,6 +291,7 @@ static int hpet_write( >> #define set_stop_timer(n) (__set_bit((n), &stop_timers)) >> #define set_start_timer(n) (__set_bit((n), &start_timers)) >> #define set_restart_timer(n) (set_stop_timer(n),set_start_timer(n)) >> + int mc_starting = 0; > ... this wants to be bool_t. Or alternatively you might want to see > whether just like in the other case you could pass guest_time in. Will change to bool_t. > With that adjusted, > Reviewed-by: Jan Beulich -Don Slutz > Jan >