From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stratos Karafotis Subject: Re: [PATCH 00/20] Introduce new cpufreq helper macros Date: Tue, 15 Apr 2014 14:03:57 +0300 Message-ID: <534D121D.9030304@semaphore.gr> References: <534C4E14.3080509@semaphore.gr> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8" To: Viresh Kumar Cc: "Rafael J. Wysocki" , "David S. Miller" , Hans-Christian Egtvedt , Dirk Brandewie , Randy Dunlap , linux-doc@vger.kernel.org, Linux Kernel Mailing List , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" On 15/04/2014 09:01 =CF=80=CE=BC, Viresh Kumar wrote: > On 15 April 2014 02:37, Stratos Karafotis wro= te: >> This patch set introduces two freq_table helper macros which >> can be used for iteration over cpufreq_frequency_table and >> makes the necessary changes to cpufreq core and drivers that >> use such an iteration procedure. >> >> The motivation was a usage of common procedure to iterate over >> cpufreq_frequency_table across all drivers and cpufreq core. >> >> This was tested on a x86_64 platform. >> Patches 4-17 compiled successfully but unfortunately I was not >> able to compile test patches 18-20. >=20 > Mostly okay, just some Nitpicks.. >=20 > Please rearrange your patches this way: > - First patch just adds the wrappers > - Second one makes changes to drivers/cpufreq/, i.e. include all core > and drivers > changes into a single patch here as the logs are exactly same. > - Then framework by framework, as we may need Acks/Reviews by them > separately.. >=20 > So, probably just 5-7 would do. >=20 Thanks for your review and your corrections! I will prepare and send the v2 according to your suggestions. Stratos