master - lvmdump: list also inactive units for lvmdump -s

master - lvmdump: list also inactive units for lvmdump -s

[Peter Rajnoha]

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=18caa562fe35b2617f5c2d04c2252b2b8fdfd08c
Commit:        18caa562fe35b2617f5c2d04c2252b2b8fdfd08c
Parent:        a6763c64a735769991170b64bb2224c861f69f3a
Author:        Peter Rajnoha <prajnoha@redhat.com>
AuthorDate:    Tue Apr 15 15:43:20 2014 +0200
Committer:     Peter Rajnoha <prajnoha@redhat.com>
CommitterDate: Tue Apr 15 15:43:20 2014 +0200

lvmdump: list also inactive units for lvmdump -s

---
 scripts/lvmdump.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/lvmdump.sh b/scripts/lvmdump.sh
index b8f73f3..9229912 100755
--- a/scripts/lvmdump.sh
+++ b/scripts/lvmdump.sh
@@ -259,7 +259,7 @@ if (( $sysreport )); then
 						   lvm2-clvmd.service \
 						   lvm2-cmirrord.service \
 						   > \"$sysreport_dir/systemd_lvm2_services_status\" 2>> \"$log\""
-		log "$SYSTEMCTL list-units -l --no-legend --no-pager > \"$sysreport_dir/systemd_unit_list\" 2>> \"$log\""
+		log "$SYSTEMCTL list-units -l -a --no-legend --no-pager > \"$sysreport_dir/systemd_unit_list\" 2>> \"$log\""
 		for unit in $(cat $sysreport_dir/systemd_unit_list | grep lvm2-pvscan | cut -d " " -f 1); do
 			log "$SYSTEMCTL status -l --no-pager -n $log_lines -o short-precise $unit >> \"$sysreport_dir/systemd_lvm2_pvscan_service_status\""
 		done

master - lvmdump: list also inactive units for lvmdump -s

[Bryn M. Reeves]

On Tue, Apr 15, 2014 at 01:43:33PM +0000, Peter Rajnoha wrote:
> lvmdump: list also inactive units for lvmdump -s
> 
> ---
>  scripts/lvmdump.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

For Red Hat (inc. Fedora, CentOS and RHEL) and recent Debian / Ubuntu
distributions you could also request an sosreport. The tool has support
for collecting lvmdump data, for e.g.:

# sosreport -o lvm2 -o systemd -klvm2.lvmdump

Would collect a similar set of data. The lvmdump option defaults to off
currently but I've considered switching this over to always collect
them.

Regards,
Bryn.

master - lvmdump: list also inactive units for lvmdump -s

[Peter Rajnoha]

On 04/15/2014 03:48 PM, Bryn M. Reeves wrote:
> On Tue, Apr 15, 2014 at 01:43:33PM +0000, Peter Rajnoha wrote:
>> lvmdump: list also inactive units for lvmdump -s
>>
>> ---
>>  scripts/lvmdump.sh |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> For Red Hat (inc. Fedora, CentOS and RHEL) and recent Debian / Ubuntu
> distributions you could also request an sosreport. The tool has support
> for collecting lvmdump data, for e.g.:
> 
> # sosreport -o lvm2 -o systemd -klvm2.lvmdump
> 
> Would collect a similar set of data. The lvmdump option defaults to off
> currently but I've considered switching this over to always collect
> them.

Well, yes, if sosreport supports that then that's fine.

The "-s" option for lvmdump is optional anyway. From my perspective,
the most valuable info I can get for debugging is the status of
"lvm2-pvscan@<major>:<minor>.service" which contains valuable logs...

-- 
Peter