All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Steve Dickson <SteveD@redhat.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: Question on nfs-utils patch for 'keyctl_invalidate'.
Date: Tue, 15 Apr 2014 21:44:48 -0700	[thread overview]
Message-ID: <534E0AC0.5050601@candelatech.com> (raw)
In-Reply-To: <534DCD52.5080202@RedHat.com>

On 04/15/2014 05:22 PM, Steve Dickson wrote:
>
>
> On 04/14/2014 08:21 PM, Ben Greear wrote:
>> It seems that key_invalidate is only available in quite recent
>> keyutils packages.
>>
>> Anyone know if there is a relatively simple way to implement
>> the same behaviour using older keyutils packages?
> CC-ing the keyutils maintainer... David, when did that kernel
> change go in that cause keyctl_revoke() to no longer work?
>
> The nfs-utils commit is:
>
> commit 2ae0763a618d30037ebb2520f6292f80d838a440
> Author: Steve Dickson <steved@redhat.com>
> Date:   Tue Mar 25 10:56:58 2014 -0400
>
>      nfsidmap: Keys need to be invalidated instead of revoked
>
> It sound like we need to do some type of #ifdef kernel version....

We might need an #ifdef based on keyutils version (which is what I implemented
to at least get it compiling), but if you need to key on kernel version then
you need run-time probing of the kernel as build system may run different
kernel than installed system.

Thanks,
Ben

>
> steved.
>
>>
>> The reason I ask is that I recently updated to latest nfs-utils
>> package and how build fails on many of my older systems...
>>
>> Thanks,
>> Ben
>>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2014-04-16  4:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  0:21 Question on nfs-utils patch for 'keyctl_invalidate' Ben Greear
2014-04-16  0:22 ` Steve Dickson
2014-04-16  4:44   ` Ben Greear [this message]
2014-04-16  6:50   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534E0AC0.5050601@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=SteveD@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.