From: Chen Gang <gang.chen.5i5j@gmail.com>
To: 管雪涛 <gxt@pku.edu.cn>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: 回复： [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h
Date: Wed, 16 Apr 2014 13:44:20 +0800 [thread overview]
Message-ID: <534E18B4.9060704@gmail.com> (raw)
In-Reply-To: <1941336741.38929.1397625571001.JavaMail.root@bj-mail03.pku.edu.cn>
On 04/16/2014 01:19 PM, 管雪涛 wrote:
> This problem has been fixed, but I didn't submit.
> Anyway, I can apply your version.
>
> Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
>
OK, thanks.
> ----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
>> Missing related ')', the related compiling error:
>>
>> CC [M] drivers/gpu/drm/udl/udl_fb.o
>> drivers/gpu/drm/udl/udl_fb.c: In function ‘udl_fb_mmap’:
>> drivers/gpu/drm/udl/udl_fb.c:273: error: expected ‘)’ before ‘return’
>> drivers/gpu/drm/udl/udl_fb.c:281: error: expected expression before ‘}’ token
>> make[4]: *** [drivers/gpu/drm/udl/udl_fb.o] Error 1
>> make[3]: *** [drivers/gpu/drm/udl] Error 2
>> make[2]: *** [drivers/gpu/drm] Error 2
>> make[1]: *** [drivers/gpu] Error 2
>> make: *** [drivers] Error 2
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> arch/unicore32/include/asm/pgtable.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/unicore32/include/asm/pgtable.h b/arch/unicore32/include/asm/pgtable.h
>> index 233c258..ed6f7d0 100644
>> --- a/arch/unicore32/include/asm/pgtable.h
>> +++ b/arch/unicore32/include/asm/pgtable.h
>> @@ -87,16 +87,16 @@ extern pgprot_t pgprot_kernel;
>>
>> #define PAGE_NONE pgprot_user
>> #define PAGE_SHARED __pgprot(pgprot_val(pgprot_user | PTE_READ \
>> - | PTE_WRITE)
>> + | PTE_WRITE))
>> #define PAGE_SHARED_EXEC __pgprot(pgprot_val(pgprot_user | PTE_READ \
>> | PTE_WRITE \
>> - | PTE_EXEC)
>> + | PTE_EXEC))
>> #define PAGE_COPY __pgprot(pgprot_val(pgprot_user | PTE_READ)
>> #define PAGE_COPY_EXEC __pgprot(pgprot_val(pgprot_user | PTE_READ \
>> - | PTE_EXEC)
>> -#define PAGE_READONLY __pgprot(pgprot_val(pgprot_user | PTE_READ)
>> + | PTE_EXEC))
>> +#define PAGE_READONLY __pgprot(pgprot_val(pgprot_user | PTE_READ))
>> #define PAGE_READONLY_EXEC __pgprot(pgprot_val(pgprot_user | PTE_READ \
>> - | PTE_EXEC)
>> + | PTE_EXEC))
>> #define PAGE_KERNEL pgprot_kernel
>> #define PAGE_KERNEL_EXEC __pgprot(pgprot_val(pgprot_kernel | PTE_EXEC))
>>
>> --
>> 1.7.9.5
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
prev parent reply other threads:[~2014-04-16 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 1:49 [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h Chen Gang
2014-04-16 5:19 ` 回复： " 管雪涛
2014-04-16 5:44 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E18B4.9060704@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=gxt@pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.