Re: [net PATCH 1/1] drivers: net: cpsw: Add default vlan for dual emac case also

[Mugunthan V N <mugunthanvnm@ti.com>]

On Tuesday 15 April 2014 07:16 PM, Yegor Yefremov wrote:
> On Wed, Apr 9, 2014 at 8:56 PM, David Miller <davem@davemloft.net> wrote:
>> From: Mugunthan V N <mugunthanvnm@ti.com>
>> Date: Wed, 9 Apr 2014 11:34:40 +0530
>>
>>> Dual EMAC works with VLAN segregation of the ports, so default vlan needs
>>> to be added in dual EMAC case else default vlan will be tagged for all
>>> egress packets and vlan unaware switches/servers will drop packets
>>> from the EVM.
> Hi Mugunthan,
>
> though this patch fixes drop packets issue, it introduces another
> issue. Just connect both interfaces to one switch and configure
> different subnets. As soon as you get a broadcast you have an endless
> loop and network communication is not possible at all. Before this
> patch you could operate as if you had really two independent NICs.
>
>

This patch doesn't add any multicast or unicast entry in the ALE table,
so there is no possible way that a broadcast packet is switched within
the two external ports, and this patch removes the encapsulation of the
default vlan id which is used for internal packet switching inside CPSW
switch from host and any packet received from external port will be
tagged with port vlan so internal switching will happen with that port
vlan-id which will be only that physical port and host port. so the
scenario which you mentioned cannot happen theoretically untill you
enable bridge between the dual ethernet interface and connect both to
the same interface.

Regards
Mugunthan V N