Re: [RFC v2 3/6] xen/arm: support guest do_suspend function

[Julien Grall <julien.grall@linaro.org>]

Hello Wei,

Thank you for the patch.

On 15/04/14 22:05, Wei Huang wrote:
> +#elif defined(__arm__) || defined(__aarch64__)
> +
> +static int modify_returncode(xc_interface *xch, uint32_t domid)
> +{
> +    vcpu_guest_context_any_t ctxt;
> +    xc_dominfo_t info;
> +    int rc;
> +
> +    if ( xc_domain_getinfo(xch, domid, 1, &info) != 1 )
> +    {
> +        PERROR("Could not get domain info");
> +        return -EINVAL;
> +    }
> +
> +    if ( (rc = xc_vcpu_getcontext(xch, domid, 0, &ctxt)) != 0 )
> +        return rc;
> +
> +    ctxt.c.user_regs.r0_usr = 1;

r0_usr is only for 32-bit. I think you need to use x0 is you are 
restoring a 64-bits guest.

Regards,

-- 
Julien Grall