From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <534E8DA1.8090101@ti.com> Date: Wed, 16 Apr 2014 10:03:13 -0400 From: Santosh Shilimkar MIME-Version: 1.0 To: Ivan Khoronzhuk , Brian Norris Subject: Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand References: <1395346112-13350-1-git-send-email-ivan.khoronzhuk@ti.com> <532B4C36.8060405@ti.com> <5343F0D6.2010804@ti.com> <20140416070833.GA5512@norris-Latitude-E6410> <534E51BF.9050508@ti.com> In-Reply-To: <534E51BF.9050508@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, m-karicheri2@ti.com, rob@landley.net, galak@codeaurora.org, dwmw2@infradead.org, Warner Losh , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote: > > On 04/16/2014 10:08 AM, Brian Norris wrote: >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote: >>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote: >>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote: >>>>> From: Murali Karicheri >>>>> Sub page write doesn't work because of hw issue in controller found on >>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which >>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible >>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option. >>>>> >>>>> Cc: Brian Norris >>>>> Cc: Warner Losh >>>>> Cc: Santosh Shilimkar >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> Signed-off-by: Ivan Khoronzhuk >>>>> --- >>>>> >>>> Acked-by: Santosh Shilimkar >>> Brian, >>> Could you pick up subj patch? >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's >> currently queued for -next (3.16). >> >> Brian > > This is a critical fix and it should be for 3.15. Yep. The NAND is broken on Keystone without this patch. So 3.15 fixes please Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Wed, 16 Apr 2014 10:03:13 -0400 Subject: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand In-Reply-To: <534E51BF.9050508@ti.com> References: <1395346112-13350-1-git-send-email-ivan.khoronzhuk@ti.com> <532B4C36.8060405@ti.com> <5343F0D6.2010804@ti.com> <20140416070833.GA5512@norris-Latitude-E6410> <534E51BF.9050508@ti.com> Message-ID: <534E8DA1.8090101@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote: > > On 04/16/2014 10:08 AM, Brian Norris wrote: >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote: >>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote: >>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote: >>>>> From: Murali Karicheri >>>>> Sub page write doesn't work because of hw issue in controller found on >>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which >>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible >>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option. >>>>> >>>>> Cc: Brian Norris >>>>> Cc: Warner Losh >>>>> Cc: Santosh Shilimkar >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> Signed-off-by: Ivan Khoronzhuk >>>>> --- >>>>> >>>> Acked-by: Santosh Shilimkar >>> Brian, >>> Could you pick up subj patch? >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's >> currently queued for -next (3.16). >> >> Brian > > This is a critical fix and it should be for 3.15. Yep. The NAND is broken on Keystone without this patch. So 3.15 fixes please Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand Date: Wed, 16 Apr 2014 10:03:13 -0400 Message-ID: <534E8DA1.8090101@ti.com> References: <1395346112-13350-1-git-send-email-ivan.khoronzhuk@ti.com> <532B4C36.8060405@ti.com> <5343F0D6.2010804@ti.com> <20140416070833.GA5512@norris-Latitude-E6410> <534E51BF.9050508@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <534E51BF.9050508@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Ivan Khoronzhuk , Brian Norris Cc: dwmw2@infradead.org, galak@codeaurora.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, rob@landley.net, linux@arm.linux.org.uk, grygorii.strashko@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, m-karicheri2@ti.com, Warner Losh List-Id: devicetree@vger.kernel.org On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote: > > On 04/16/2014 10:08 AM, Brian Norris wrote: >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote: >>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote: >>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote: >>>>> From: Murali Karicheri >>>>> Sub page write doesn't work because of hw issue in controller found on >>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which >>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible >>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option. >>>>> >>>>> Cc: Brian Norris >>>>> Cc: Warner Losh >>>>> Cc: Santosh Shilimkar >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> Signed-off-by: Ivan Khoronzhuk >>>>> --- >>>>> >>>> Acked-by: Santosh Shilimkar >>> Brian, >>> Could you pick up subj patch? >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's >> currently queued for -next (3.16). >> >> Brian > > This is a critical fix and it should be for 3.15. Yep. The NAND is broken on Keystone without this patch. So 3.15 fixes please Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161339AbaDPOE1 (ORCPT ); Wed, 16 Apr 2014 10:04:27 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55630 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161077AbaDPOEY (ORCPT ); Wed, 16 Apr 2014 10:04:24 -0400 Message-ID: <534E8DA1.8090101@ti.com> Date: Wed, 16 Apr 2014 10:03:13 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Ivan Khoronzhuk , Brian Norris CC: , , , , , , , , , , , , , , Warner Losh Subject: Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand References: <1395346112-13350-1-git-send-email-ivan.khoronzhuk@ti.com> <532B4C36.8060405@ti.com> <5343F0D6.2010804@ti.com> <20140416070833.GA5512@norris-Latitude-E6410> <534E51BF.9050508@ti.com> In-Reply-To: <534E51BF.9050508@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote: > > On 04/16/2014 10:08 AM, Brian Norris wrote: >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote: >>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote: >>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote: >>>>> From: Murali Karicheri >>>>> Sub page write doesn't work because of hw issue in controller found on >>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which >>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible >>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option. >>>>> >>>>> Cc: Brian Norris >>>>> Cc: Warner Losh >>>>> Cc: Santosh Shilimkar >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> Signed-off-by: Ivan Khoronzhuk >>>>> --- >>>>> >>>> Acked-by: Santosh Shilimkar >>> Brian, >>> Could you pick up subj patch? >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's >> currently queued for -next (3.16). >> >> Brian > > This is a critical fix and it should be for 3.15. Yep. The NAND is broken on Keystone without this patch. So 3.15 fixes please Regards, Santosh