Re: [PATCH] mlx4_en: don't use napi_synchronize inside mlx4_en_netpoll

[Amir Vadai <amirv@mellanox.com>]

On 4/16/2014 1:09 AM, Chris Mason wrote:
>
>
> The mlx4 driver is triggering schedules while atomic inside
> mlx4_en_netpoll:
>
> 	spin_lock_irqsave(&cq->lock, flags);
> 	napi_synchronize(&cq->napi);
> 		^^^^^ msleep here
> 	mlx4_en_process_rx_cq(dev, cq, 0);
> 	spin_unlock_irqrestore(&cq->lock, flags);
>
> This was part of a patch by Alexander Guller from Mellanox in 2011,
> but it still isn't upstream.
>
> Signed-off-by: Chris Mason <clm@fb.com>
> cc: stable@vger.kernel.org
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_cq.c     | 1 -
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 6 +-----
>   drivers/net/ethernet/mellanox/mlx4/mlx4_en.h   | 1 -
>   3 files changed, 1 insertion(+), 7 deletions(-)
>

Acked-By: Amir Vadai <amirv@mellanox.com>