From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrew Bresticker <abrestic@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: as3722: fix handling of GPIO invert bit
Date: Wed, 16 Apr 2014 10:21:04 -0600 [thread overview]
Message-ID: <534EADF0.1020907@wwwdotorg.org> (raw)
In-Reply-To: <1397611505-17917-1-git-send-email-abrestic@chromium.org>
On 04/15/2014 07:25 PM, Andrew Bresticker wrote:
> The AS3722_GPIO_INV bit will always be blindly overwritten by
> as3722_pinctrl_gpio_set_direction() and will be ignored when
> setting the value of the GPIO in as3722_gpio_set() since the
> enable_gpio_invert flag is never set. This will cause an
> initially inverted GPIO to toggle when requested as an output,
> which could be problematic if, for example, the GPIO controls
> a critical regulator.
>
> Instead of setting up the enable_gpio_invert flag, uust leave
> the invert bit alone and check it before setting the GPIO value.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
(not with a 'scope or anything, but an affected system boots in a stable
fashion with this applied)
Should this be CC: stable?
next prev parent reply other threads:[~2014-04-16 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 1:25 [PATCH] pinctrl: as3722: fix handling of GPIO invert bit Andrew Bresticker
2014-04-16 16:21 ` Stephen Warren [this message]
2014-04-16 20:29 ` Andrew Bresticker
[not found] ` <1397611505-17917-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-16 20:40 ` [PATCH v2] " Andrew Bresticker
2014-04-16 20:40 ` Andrew Bresticker
[not found] ` <1397680817-28470-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-22 15:05 ` Linus Walleij
2014-04-22 15:05 ` Linus Walleij
2014-04-17 9:48 ` [PATCH] " Laxman Dewangan
2014-04-17 9:48 ` Laxman Dewangan
[not found] ` <534FA35B.6060005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-17 16:43 ` Andrew Bresticker
2014-04-17 16:43 ` Andrew Bresticker
[not found] ` <CAL1qeaG+MBmBZ3dD6LZwV5mh5A=u+0N7Obt43UwhViaBYpXxpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-17 17:24 ` Laxman Dewangan
2014-04-17 17:24 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EADF0.1020907@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=abrestic@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.