All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] dma: mmp_pdma: add support for residue reporting
Date: Wed, 16 Apr 2014 18:40:22 +0200	[thread overview]
Message-ID: <534EB276.4000408@zonque.org> (raw)
In-Reply-To: <20140416160109.GU32284@intel.com>

On 04/16/2014 06:01 PM, Vinod Koul wrote:
> On Wed, Apr 16, 2014 at 04:59:13PM +0200, Daniel Mack wrote:
>> On 04/16/2014 11:09 AM, Vinod Koul wrote:
>>> On Wed, Apr 16, 2014 at 10:38:10AM +0200, Daniel Mack wrote:
>>>>>> It might add to the readability of the drivers, but for the current
>>>>>> case, I don't think it's really necessary.
>>>>> That is because you are maintaining the current descriptors in chain_running. If
>>>>> we use above method then you dont need to use this, right?
>>>>
>>>> Jup, but that would result in a rewrite of larger parts of the code. The
>>>> concept of hot-linking the two list so there's only one resulting list
>>>> of currently active descriptors is built-in deeply into the driver's
>>>> concept.
>>> Ah I suspected so :)
>>>
>>> I think for now this is fine you can perhaps upgrade this later :)
>>
>> So, do you want me to resend with the minor dma_set_residue() change?
> Yes please...
> 

Ah, just checked again and my call to

	dma_set_residue(txstate, mmp_pdma_residue(chan, cookie));

resolves to ...

static inline void dma_set_residue(struct dma_tx_state *state, u32 residue)
{
        if (state)
                state->residue = residue;
}


So there's no need to check for txstate != NULL on the caller side :)


Thanks,
Daniel

  reply	other threads:[~2014-04-16 16:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 11:29 [PATCH RESEND] dma: mmp_pdma: add support for residue reporting Daniel Mack
2014-03-19 15:13 ` Vinod Koul
2014-04-09 16:35   ` Daniel Mack
2014-04-16  6:45     ` Vinod Koul
2014-04-16  8:28       ` Daniel Mack
2014-04-16  8:23         ` Vinod Koul
2014-04-16  8:38           ` Daniel Mack
2014-04-16  9:09             ` Vinod Koul
2014-04-16 14:59               ` Daniel Mack
2014-04-16 16:01                 ` Vinod Koul
2014-04-16 16:40                   ` Daniel Mack [this message]
2014-05-02 22:29                     ` Daniel Mack
2014-05-07  7:04                       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534EB276.4000408@zonque.org \
    --to=daniel@zonque.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.