From: Randy Dunlap <rdunlap@infradead.org>
To: Doug Anderson <dianders@chromium.org>,
Anton Vorontsov <anton@enomsg.org>
Cc: Olof Johansson <olof@lixom.net>,
Sachin Kamat <sachin.kamat@linaro.org>,
ajaykumar.rs@samsung.com, linux-samsung-soc@vger.kernel.org,
Simon Glass <sjg@chromium.org>,
Michael Spang <spang@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] regulator: tps65090: Allow setting the overcurrent wait time
Date: Wed, 16 Apr 2014 13:33:14 -0700 [thread overview]
Message-ID: <534EE90A.7070602@infradead.org> (raw)
In-Reply-To: <1397672724-9063-5-git-send-email-dianders@chromium.org>
On 04/16/2014 11:25 AM, Doug Anderson wrote:
> diff --git a/drivers/regulator/tps65090-regulator.c b/drivers/regulator/tps65090-regulator.c
> index 2e92ef6..ca13a1a 100644
> --- a/drivers/regulator/tps65090-regulator.c
> +++ b/drivers/regulator/tps65090-regulator.c
> @@ -28,15 +28,57 @@
> +/**
> + * tps65090_reg_set_overcurrent_wait - Setup overcurrent wait
> + *
> + * This will set the overcurrent wait time based on what's in the regulator
> + * info.
> + *
> + * @ri: Overall regulator data
> + * @rdev: Regulator device
> + * @return 0 if no error, non-zero if there was an error writing the register.
kernel-doc notation here should be:
* Return: 0 if no error, non-zero if there was an error writing the register.
> + */
> +static int tps65090_reg_set_overcurrent_wait(struct tps65090_regulator *ri,
> + struct regulator_dev *rdev)
> +{
--
~Randy
next prev parent reply other threads:[~2014-04-16 20:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 20:14 [PATCH 0/3] Fixes for tps65090 for Samsung ARM Chromebook Doug Anderson
2014-04-15 20:14 ` [PATCH 1/3] mfd: tps65090: Allow charger module to be used when no irq Doug Anderson
2014-04-16 9:52 ` Lee Jones
2014-04-16 15:42 ` Doug Anderson
2014-04-16 16:26 ` Lee Jones
2014-04-16 17:45 ` Doug Anderson
2014-04-16 19:03 ` Lee Jones
2014-04-15 20:14 ` [PATCH 2/3] mfd: tps65090: Stop caching registers Doug Anderson
2014-04-16 9:59 ` Lee Jones
2014-04-16 10:13 ` Mark Brown
2014-04-16 18:27 ` Doug Anderson
2014-04-15 20:14 ` [PATCH 3/3] regulator: tps65090: Make FETs more reliable Doug Anderson
[not found] ` <1397592876-5741-4-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-04-15 22:52 ` Mark Brown
2014-04-15 22:52 ` Mark Brown
2014-04-16 18:28 ` Doug Anderson
2014-04-16 18:25 ` [PATCH v2 0/5] Fixes for tps65090 for Samsung ARM Chromebook Doug Anderson
2014-04-16 18:25 ` [PATCH v2 1/5] mfd: tps65090: Don't tell child devices we have an IRQ if we don't Doug Anderson
2014-04-16 18:25 ` [PATCH v2 2/5] charger: tps65090: Allow charger module to be used when no irq Doug Anderson
2014-04-16 18:25 ` [PATCH v2 3/5] mfd: tps65090: Stop caching most registers Doug Anderson
2014-04-16 18:25 ` [PATCH v2 4/5] regulator: tps65090: Allow setting the overcurrent wait time Doug Anderson
2014-04-16 20:33 ` Randy Dunlap [this message]
2014-04-16 23:12 ` Doug Anderson
2014-04-16 18:25 ` [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries Doug Anderson
2014-04-16 20:50 ` Simon Glass
2014-04-16 21:25 ` Doug Anderson
2014-04-16 23:24 ` Simon Glass
2014-04-16 20:51 ` Mark Brown
2014-04-16 21:34 ` Doug Anderson
2014-04-16 21:54 ` Mark Brown
2014-04-16 22:59 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EE90A.7070602@infradead.org \
--to=rdunlap@infradead.org \
--cc=ajaykumar.rs@samsung.com \
--cc=anton@enomsg.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=sjg@chromium.org \
--cc=spang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.