From: "H. Peter Anvin" <hpa@zytor.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
Nadav Amit <namit@cs.technion.ac.il>
Cc: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix page-tables reserved bits
Date: Wed, 16 Apr 2014 14:17:08 -0700 [thread overview]
Message-ID: <534EF354.3090204@zytor.com> (raw)
In-Reply-To: <20140416190329.GB8773@amt.cnet>
On 04/16/2014 12:03 PM, Marcelo Tosatti wrote:
>> @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu,
>> break;
>> case PT64_ROOT_LEVEL:
>> context->rsvd_bits_mask[0][3] = exb_bit_rsvd |
>> - rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 8);
>> + rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 7);
>> context->rsvd_bits_mask[0][2] = exb_bit_rsvd |
>> - rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 8);
>> + rsvd_bits(maxphyaddr, 51) | rsvd_bits(7, 7);
>
> Bit 7 is not reserved either, for the PDPTE (its PageSize bit).
>
In long mode (IA-32e), bit 7 is definitely reserved.
-hpa
next prev parent reply other threads:[~2014-04-16 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 3:31 [PATCH] KVM: x86: Fix page-tables reserved bits Nadav Amit
2014-04-16 19:03 ` Marcelo Tosatti
2014-04-16 21:17 ` H. Peter Anvin [this message]
2014-04-16 22:04 ` Marcelo Tosatti
2014-04-28 10:41 ` Paolo Bonzini
2014-04-28 12:20 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EF354.3090204@zytor.com \
--to=hpa@zytor.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.