All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Ryzhov <iryzhov@arccn.ru>
To: Peter Maydell <peter.maydell@linaro.org>,  Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma.
Date: Thu, 17 Apr 2014 01:19:48 +0400	[thread overview]
Message-ID: <534EF3F4.7080803@arccn.ru> (raw)
In-Reply-To: <CAFEAcA8xSPkrAhG8c_FjoXh2qcYL0C32pPH9dHTjg-wAcprgfw@mail.gmail.com>

Oh, my mistake.
It's really semicolon, not comma :)

Should I resend the patch with correct name?

16.04.2014 21:58, Peter Maydell пишет:
> On 16 April 2014 18:32, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 16.04.2014 15:43, schrieb Igor Ryzhov:
>>> Signed-off-by: Igor Ryzhov <iryzhov@arccn.ru>
>>> ---
>>>   net/net.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/net.c b/net/net.c
>>> index e3ef1e4..60a07f1 100644
>>> --- a/net/net.c
>>> +++ b/net/net.c
>>> @@ -473,7 +473,7 @@ ssize_t qemu_deliver_packet(NetClientState *sender,
>>>
>>>       if (ret == 0) {
>>>           nc->receive_disabled = 1;
>>> -    };
>>> +    }
>>>
>>>       return ret;
>>>   }
>>>
>> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>>
>> CC'ing qemu-trivial
>>
>> PS. The "." at the end of your subject line is unnecessary, too. :-)
> "net/net.c: Remove unnecessary semicolon" would probably
> be better (since it lets people know which area the patch is affecting
> and also gets the name of the punctuation mark right ;-)).
>
> thanks
> -- PMM



  reply	other threads:[~2014-04-17 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1397655787-27780-1-git-send-email-iryzhov@arccn.ru>
2014-04-16 17:32 ` [Qemu-trivial] [Qemu-devel] [PATCH] Unnecessary comma Stefan Weil
2014-04-16 17:58   ` Peter Maydell
2014-04-16 21:19     ` Igor Ryzhov [this message]
2014-04-27  9:10   ` [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534EF3F4.7080803@arccn.ru \
    --to=iryzhov@arccn.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.