All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glyn Normington <gnormington@gopivotal.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] control groups: documentation improvements
Date: Thu, 17 Apr 2014 14:45:40 +0100	[thread overview]
Message-ID: <534FDB04.6050406@gopivotal.com> (raw)
In-Reply-To: <20140417131615.GH26632@htj.dyndns.org>

Hi Tejun

On 17/04/2014 14:16, Tejun Heo wrote:
> Hello, Glyn.
>
> On Thu, Apr 17, 2014 at 11:46:13AM +0100, Glyn Normington wrote:
>> +There may be zero or more active hierarchies. Each hierarchy has an
>> +instance of the cgroup virtual filesystem associated with it. The tree
>> +of cgroups is represented by the directory tree in the cgroup virtual
>> +filesystem.
>> +
>> +The sets of subsystems participating in distinct hierarchies are either
>> +identical or disjoint. If the sets are identical, the virtual filesystems
>> +associated with the hierarchies have identical content and a change in
>> +one is automatically reflected in all the others.
> I can't say I'm a big fan of these definitions in mathematical terms.
> They're so precise and useless at the same time.
We would like to be both precise and readable. Please point out the 
"useless" bits and we'll try to make them better.
> That said, I don't
> really understand the last paragraph.  Is it trying to talk about
> multiple mounts of a single hierarchy?
Yes. When this came up earlier, Li Zefan thought we could delete that 
paragraph "because we all know the same filesystem can have more than 
one mount point and cgroupfs is no different". But since the underlying 
cgroupfs is only visible through the representation(s) at its mount 
points, we'd prefer to keep the paragraph.

How about changing the  paragraph to say:

A given hierarchy may be associated with more than one virtual 
filesystem, in which case each of the virtual filesystems has identical 
contents to the others.

?
>
> Thanks.
Regards,
Glyn

  reply	other threads:[~2014-04-17 13:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 11:39 [PATCH] control groups: documentation improvements Glyn Normington
2014-03-10 14:07 ` Tejun Heo
2014-03-10 14:17   ` Glyn Normington
2014-03-10 14:20     ` Tejun Heo
2014-03-13 16:04       ` Glyn Normington
2014-03-14  1:33         ` Li Zefan
2014-03-14 13:30           ` Glyn Normington
2014-03-14 14:01             ` Tejun Heo
2014-03-14 14:04               ` Glyn Normington
2014-04-02 12:43                 ` [PATCH v2] " Glyn Normington
2014-04-02 13:17                   ` [PATCH v3] " Glyn Normington
2014-04-16 21:00                     ` Tejun Heo
2014-04-17 10:46                       ` [PATCH v4] " Glyn Normington
2014-04-17 13:16                         ` Tejun Heo
2014-04-17 13:45                           ` Glyn Normington [this message]
2014-04-17 13:55                             ` Tejun Heo
2014-04-17 14:51                               ` Glyn Normington
2014-04-17 14:57                                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534FDB04.6050406@gopivotal.com \
    --to=gnormington@gopivotal.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.