From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Added support for PIN retry count.
Date: Thu, 17 Apr 2014 10:53:35 -0500 [thread overview]
Message-ID: <534FF8FF.30909@gmail.com> (raw)
In-Reply-To: <1397660884-29140-1-git-send-email-jussi.pakkanen@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
Hi Jussi,
On 04/16/2014 10:08 AM, jussi.pakkanen(a)canonical.com wrote:
> Hi
>
> Sorry, had a bit of a Git mixup in the previous patch. Here's the correct one,
> now comes with the =? query interface as well as standards conforming output.
>
> ---
> src/default.xml | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
Patch looks fine to me, but can you please fix the patch description?
Also, please get in the habit of adding version information to your
patches, e.g. using '[PATCH v2] foo: bar'. That way it is easier for
the maintainers to track which patch to pay attention to.
Regards,
-Denis
next prev parent reply other threads:[~2014-04-17 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:08 [PATCH] Added support for PIN retry count jussi.pakkanen
2014-04-17 15:53 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-16 14:26 jussi.pakkanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534FF8FF.30909@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.