From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH RFC 20/23] xenstat: add a dummy FreeBSD
	implementation
Date: Thu, 17 Apr 2014 19:25:43 +0200
Message-ID: <53500E97.5070706@citrix.com>
References: <1397657612-57277-1-git-send-email-roger.pau@citrix.com>	<1397657612-57277-21-git-send-email-roger.pau@citrix.com>
	<21328.3131.521126.475425@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1Waq4K-0000EF-BG
	for xen-devel@lists.xenproject.org; Thu, 17 Apr 2014 17:25:48 +0000
In-Reply-To: <21328.3131.521126.475425@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/04/14 19:15, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH RFC 20/23] xenstat: add a dummy FreeBSD implementation"):
>> Add an empty FreeBSD implementation so xenstat can compile on FreeBSD.
> 
> Not an area I'm very familiar with.
> 
> Have you tried running xentop with this patch and seen what it does ?

Yes, disk and network stats are not reported, here is a sample output:

      NAME  STATE   CPU(sec) CPU(%)     MEM(k) MEM(%)  MAXMEM(k) MAXMEM(%) VCPUS NETS NETTX(k) NETRX(k) VBDS   VBD_OO   VBD_RD   VBD_WR  VBD_RSECT  VBD_WSECT SSID
  Domain-0 -----r        697    0.0    1048568   16.7   no limit       n/a     2    0        0     0    0        0        0        0          0          0    0
      test --b---          7    0.0     524288    8.3     525312       8.4     1    0        0     0    0        0        0        0          0          0    0

Roger.