From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Bjorn Helgaas <bhelgaas@google.com>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: Alexander Gordeev <agordeev@redhat.com>,
linux-can@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value
Date: Thu, 17 Apr 2014 22:11:35 +0200 [thread overview]
Message-ID: <53503577.1020809@pengutronix.de> (raw)
In-Reply-To: <CAErSpo4hujoq8Ni7sSrNQv61rf4Xz4s3GjYxNQR6TDLDm0N-Jw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On 04/03/2014 06:53 PM, Bjorn Helgaas wrote:
> Coverity complains that c_can_pci_probe() calls pci_enable_msi()
> without checking the result:
>
>
> CID 712278 (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 3. check_return: Calling pci_enable_msi_block without checking return
> value (as is done elsewhere 88 out of 105 times).
> 88 pci_enable_msi(pdev);
>
> This is CID 712278.
Thanks, I've applied Wolfgang's patch ("can: c_can_pci: enable PCI bus
master only for MSI"), which fixes this problem.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-04-17 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:53 Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value Bjorn Helgaas
2014-04-17 20:11 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53503577.1020809@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.