From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
guohanjun@huawei.com, Kefeng Wang <kefeng.wang@linaro.org>
Subject: Re: [PATCH V2 2/2] ahci: add support for Hisilicon sata
Date: Fri, 18 Apr 2014 09:07:12 +0800 [thread overview]
Message-ID: <53507AC0.4020602@huawei.com> (raw)
In-Reply-To: <20140417133151.GC15326@htj.dyndns.org>
On 04/17 21:31, Tejun Heo wrote:
> On Thu, Apr 17, 2014 at 09:48:03AM +0200, Hans de Goede wrote:
>>> Hmmm.... this should work but looks a bit tedious and it could be
>>> better to have a better mechanism to match devices to their
>>> port_infos. Hans, can you please comment? If getting something more
>>> structured is too much work, I can go with this but wanna find out
>>> whether that's the case.
>>
>> The more structured solution would be v1 of this patch, which I asked
>> Kefan to change since it seemed overkill. But if you prefer that version
>> that is fine with me.
>
> I don't care either way at this point but if this grows to a large
> list, having a matching mechanism will probably be more manageable.
>
>> Note that as I've already mentioned earlier in the thread this could be
>> made somewhat cleaner by having an host_flags parameter to
>> ahci_platform_init_host().
>
> Kefeng, can you please update accordingly to Hans' comment and repost?
Sure, Thanks for the advice from you and Hans, will update.
>
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <guohanjun@huawei.com>,
Kefeng Wang <kefeng.wang@linaro.org>
Subject: Re: [PATCH V2 2/2] ahci: add support for Hisilicon sata
Date: Fri, 18 Apr 2014 09:07:12 +0800 [thread overview]
Message-ID: <53507AC0.4020602@huawei.com> (raw)
In-Reply-To: <20140417133151.GC15326@htj.dyndns.org>
On 04/17 21:31, Tejun Heo wrote:
> On Thu, Apr 17, 2014 at 09:48:03AM +0200, Hans de Goede wrote:
>>> Hmmm.... this should work but looks a bit tedious and it could be
>>> better to have a better mechanism to match devices to their
>>> port_infos. Hans, can you please comment? If getting something more
>>> structured is too much work, I can go with this but wanna find out
>>> whether that's the case.
>>
>> The more structured solution would be v1 of this patch, which I asked
>> Kefan to change since it seemed overkill. But if you prefer that version
>> that is fine with me.
>
> I don't care either way at this point but if this grows to a large
> list, having a matching mechanism will probably be more manageable.
>
>> Note that as I've already mentioned earlier in the thread this could be
>> made somewhat cleaner by having an host_flags parameter to
>> ahci_platform_init_host().
>
> Kefeng, can you please update accordingly to Hans' comment and repost?
Sure, Thanks for the advice from you and Hans, will update.
>
> Thanks.
>
next prev parent reply other threads:[~2014-04-18 1:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 5:24 [PATCH V2 0/2] ahci: support for hisilicon sata Kefeng Wang
2014-04-10 5:24 ` Kefeng Wang
2014-04-10 5:24 ` [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS Kefeng Wang
2014-04-10 5:24 ` Kefeng Wang
2014-04-16 20:49 ` Tejun Heo
2014-04-10 5:24 ` [PATCH V2 2/2] ahci: add support for Hisilicon sata Kefeng Wang
2014-04-10 5:24 ` Kefeng Wang
2014-04-16 20:49 ` Tejun Heo
2014-04-17 7:48 ` Hans de Goede
2014-04-17 13:31 ` Tejun Heo
2014-04-18 1:07 ` Kefeng Wang [this message]
2014-04-18 1:07 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53507AC0.4020602@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=guohanjun@huawei.com \
--cc=hdegoede@redhat.com \
--cc=kefeng.wang@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.