All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] configure: Exit with code 0 with --help
Date: Fri, 18 Apr 2014 10:32:50 +0400	[thread overview]
Message-ID: <5350C712.90201@msgid.tls.msk.ru> (raw)
In-Reply-To: <1397802352-27814-1-git-send-email-famz@redhat.com>

18.04.2014 10:25, Fam Zheng wrote:
> There are two paths to show help and exit, one is with "-h" or "--help",
> one is with invalid options.
> 
> Only "exit 1" with the latter case.

I'd rather put `exit 1' right in invalid option case, instead of jumping
to help.  Because help output is huge, and it is often difficult to see
the error message.   At max, at the error case, the script can output
something like, `for a list of valid options, run $0 --help'.

Here and for qemu-img case.

Do you not agree?

Thanks,

/mjt


      reply	other threads:[~2014-04-18  6:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18  6:25 [Qemu-trivial] [PATCH] configure: Exit with code 0 with --help Fam Zheng
2014-04-18  6:32 ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5350C712.90201@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.