From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: mvebu: specify I2C bus frequency on Armada 370 DB
Date: Fri, 18 Apr 2014 09:47:29 +0200 [thread overview]
Message-ID: <5350D891.4050609@free-electrons.com> (raw)
In-Reply-To: <1397806908-7550-2-git-send-email-thomas.petazzoni@free-electrons.com>
On 18/04/2014 09:41, Thomas Petazzoni wrote:
> In commit 249f3822509b74f8c8d0731aeb7ccea065376c9b ('ARM: mvebu: add
> audio support to Armada 370 DB'), the I2C bus 0 was enabled on the
> Armada 370 DB board, and an I2C codec was described as being connected
> on this bus.
>
> However, this commit forgot to define the I2C bus frequency, which
> leads the i2c-mv64xxx to fail probing, as it cannot calculate the baud
> rate multiplier/divisor to derive the I2C bus frequency from the core
> SoC frequency. It makes audio completely unusable, as the I2C bus is
> not probed, and therefore the audio codec is not probed either.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> The audio support was merged in 3.15-rc1, so there's no need to
> backport this change into stable trees. However, it needs to go in the
> 3.15-rc cycle.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/boot/dts/armada-370-db.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
> index 82f238a..3383c4b 100644
> --- a/arch/arm/boot/dts/armada-370-db.dts
> +++ b/arch/arm/boot/dts/armada-370-db.dts
> @@ -67,6 +67,7 @@
> i2c at 11000 {
> pinctrl-0 = <&i2c0_pins>;
> pinctrl-names = "default";
> + clock-frequency = <100000>;
> status = "okay";
> audio_codec: audio-codec at 4a {
> compatible = "cirrus,cs42l51";
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-04-18 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 7:41 [PATCH 0/5] ARM: mvebu: misc Device Tree fixes and updates Thomas Petazzoni
2014-04-18 7:41 ` [PATCH 1/5] ARM: mvebu: specify I2C bus frequency on Armada 370 DB Thomas Petazzoni
2014-04-18 7:47 ` Gregory CLEMENT [this message]
2014-04-18 7:41 ` [PATCH 2/5] ARM: mvebu: enable the SATA interface on Armada 375 DB Thomas Petazzoni
2014-04-18 7:47 ` Gregory CLEMENT
2014-04-18 7:41 ` [PATCH 3/5] ARM: mvebu: use clocks property for serial ports Thomas Petazzoni
2014-04-18 7:49 ` Gregory CLEMENT
2014-04-18 7:41 ` [PATCH 4/5] ARM: mvebu: remove clock-frequency of serial port Device Tree nodes Thomas Petazzoni
2014-04-18 7:49 ` Gregory CLEMENT
2014-04-18 7:41 ` [PATCH 5/5] ARM: mvebu: don't use clocks property in UART node for Netgear RN2120 Thomas Petazzoni
2014-04-18 7:50 ` Gregory CLEMENT
2014-04-20 19:00 ` [PATCH 0/5] ARM: mvebu: misc Device Tree fixes and updates Jason Cooper
2014-04-26 0:37 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5350D891.4050609@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.