All of lore.kernel.org
 help / color / mirror / Atom feed
From: ipaton0@gmail.com (Iain Paton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6: clk: i.MX6 DualLite/Solo i2c4 clock
Date: Fri, 18 Apr 2014 14:25:52 +0100	[thread overview]
Message-ID: <535127E0.2070106@gmail.com> (raw)
In-Reply-To: <20140417130004.GC22160@dragon>

On 17/04/14 14:00, Shawn Guo wrote:
> On Thu, Apr 17, 2014 at 03:41:11PM +0300, Vladimir Zapolskiy wrote:
>> On 04/16/14 21:33, Iain Paton wrote:
>>> -	clk[ecspi5]       = imx_clk_gate2("ecspi5",        "ecspi_root",        base + 0x6c, 8);
>>> +	if (cpu_is_imx6dl())
>>> +		/*
>>> +		 * ecspi5 is replaced with i2c4 on imx6dl&  imx6s
>>> +		 */
>>> +		clk[ecspi5] = imx_clk_gate2("i2c4",        "ipg_per",           base + 0x6c, 8);
>>
>> Is it good enough to reuse ecspi5 enum value here or may it be
>> better to introduce a new one i2c4 equal to ecspi5?
> 
> With the comment in there, it's just fine to reuse the enum, I think.

I wasn't sure about that, but couldn't find anywhere else the enum was used. In 
the dts the clock is simply referenced as <&clks 116> so you have to work that
back manually.

If you think it's worth it to add something to 
Documentation/devicetree/bindings/clock/imx6q-clock.txt so that the difference 
is documented I can send a patch for that.

Iain

      reply	other threads:[~2014-04-18 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 18:33 [PATCH] ARM: imx6: clk: i.MX6 DualLite/Solo i2c4 clock Iain Paton
2014-04-17  5:01 ` Shawn Guo
2014-04-17 12:41 ` Vladimir Zapolskiy
2014-04-17 13:00   ` Shawn Guo
2014-04-18 13:25     ` Iain Paton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535127E0.2070106@gmail.com \
    --to=ipaton0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.