All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] crypt(3): use real dashes in regex
Date: Fri, 18 Apr 2014 17:53:05 +0200	[thread overview]
Message-ID: <53514A61.3060809@gmail.com> (raw)
In-Reply-To: <3245891.ebzCqChYRm@vapier>

On 04/17/2014 09:55 PM, Mike Frysinger wrote:
> On Thu 17 Apr 2014 21:22:31 Michael Kerrisk wrote:
>> On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger wrote:
>>> I don't think rendering the dashes in the regex expression as the en
>>> style makes sense.  This is a literal regex, so use literal dashes.
>>
>> I agree, but it looks like your patch is inconsistent. But you use
>> '\-' in one part of the patch (right), and just '-' in the other part.
>> How come?
> 
> i wrote the two hunks on different days.  iiuc, they should all be \-.

Applied (and fixed, as discussed).

Thanks, Mike.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2014-04-18 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 17:48 [PATCH] crypt(3): use real dashes in regex Mike Frysinger
     [not found] ` <1397756918-16350-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2014-04-17 19:22   ` Michael Kerrisk (man-pages)
     [not found]     ` <CAKgNAkh4yU=nnEVoWA0g36bQovg6csR-ik54Z0FT3Q53Hrn8-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-17 19:55       ` Mike Frysinger
2014-04-17 20:09         ` Michael Kerrisk (man-pages)
2014-04-18 15:53         ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53514A61.3060809@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.