From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
suravee.suthikulpanit@amd.com, Tim Deegan <tim@xen.org>,
Eddie Dong <eddie.dong@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4/6] x86/NPT: don't walk entire page tables when changing types on a range
Date: Fri, 18 Apr 2014 18:01:40 -0400 [thread overview]
Message-ID: <5351A0C4.8070807@oracle.com> (raw)
In-Reply-To: <53501375020000780000A1C4@nat28.tlf.novell.com>
On 04/17/2014 11:46 AM, Jan Beulich wrote:
> This builds on the fact that in order for no NPF VM exit to occur,
> _PAGE_USER must always be set. I.e. by clearing the flag we can force a
> VM exit allowing us to do similar lazy type changes as on EPT.
>
> That way, the generic entry-wise code can go away, and we could remove
> the range restriction in enforced on HVMOP_track_dirty_vram for XSA-27.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
I am not particularly familiar with p2m code which is why my only
comment so far is to add comments in the code ;-) --- there is a bunch
of new non-trivial (to my eye) routines and so having a little bit of
text would greatly help with understanding the logic.
-boris
next prev parent reply other threads:[~2014-04-18 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:39 [PATCH 0/6] x86/P2M: reduce time group type changes take Jan Beulich
2014-04-17 15:43 ` [PATCH 1/6] x86/EPT: don't walk entire page tables when globally changing types Jan Beulich
2014-04-17 15:44 ` [PATCH 2/6] x86/EPT: don't walk entire page tables when changing types on a range Jan Beulich
2014-04-17 15:45 ` [PATCH 3/6] x86/P2M: simplify write_p2m_entry() Jan Beulich
2014-04-17 15:46 ` [PATCH 4/6] x86/NPT: don't walk entire page tables when changing types on a range Jan Beulich
2014-04-18 22:01 ` Boris Ostrovsky [this message]
2014-04-17 15:47 ` [PATCH 5/6] x86/NPT: don't walk entire page tables when globally changing types Jan Beulich
2014-04-17 15:47 ` [PATCH 6/6] x86/P2M: cleanup Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5351A0C4.8070807@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.