All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Ryan Desfosses <ryan@desfo.org>, bhelgaas@google.com
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/8] patch series
Date: Fri, 18 Apr 2014 17:25:53 -0700	[thread overview]
Message-ID: <5351C291.40200@infradead.org> (raw)
In-Reply-To: <1397866610-21328-1-git-send-email-ryan@desfo.org>

On 04/18/2014 05:16 PM, Ryan Desfosses wrote:
> There are eight patches in this series.  All changes are trivial with no
> dependencies or required order.
> --

My small comments:

a. The Subject should have mentioned PCI and trivial.

b. Please use imperative mood for patch descriptions.  I.e.,

use remove instead of removed;
use move instead of moved;
use merge instead of merged;
use add instead of added.


Don't resend the patches based only on my comments (unless the PCI
maintainer asks you to do so).


thanks,
-- 
~Randy

  reply	other threads:[~2014-04-19  0:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-19  0:16 [PATCH 0/8] patch series Ryan Desfosses
2014-04-19  0:25 ` Randy Dunlap [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-04-19  0:13 Ryan Desfosses

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5351C291.40200@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ryan@desfo.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.