Re: 3.14 issue with i810 graphic card bisected

[Tobias Powalowski <tobias.powalowski@googlemail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1108 bytes --]

Am 18.04.2014 22:38, schrieb Tejun Heo:
> Hello,
>
> Sorry about the long delay.
>
> On Thu, Apr 03, 2014 at 08:37:49AM +0200, Tobias Powalowski wrote:
>> Hi,
>> I bisected a X startup crash due to new 3.14 kernel:
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/kernfs/file.c?id=9b2db6e1894577d48f4e290381bac6e573593838
>> It's an old intel 810 graphics card which got broken.
>> dmesg and xorg.log attached.
> Hmm... I'm stumped.  The patch shouldn't cause any visible difference
> to the userland.  I went over it a couple more times and still can't
> see how this would make any difference.  Can you please do the
> followings?
>
> * Repeat the test on v3.14 with only the patch reverted.  If it makes
>   the problem go away reliably,
>
> * strace X startup on v3.14 and v3.14 sans the offending patch.
>
> Thanks!
>
Hi shortened the patch,
indeed only the 5 lines are the error source.
Patch attached.

greetings
tpowa

-- 
Tobias Powalowski
Archlinux Developer & Package Maintainer (tpowa)
http://www.archlinux.org
tpowa@archlinux.org


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: fix-i810-short.patch --]
[-- Type: text/x-patch; name="fix-i810-short.patch", Size: 396 bytes --]

--- linux-3.14/fs/kernfs/file.c.orig	2014-03-31 05:40:15.000000000 +0200
+++ linux-3.14/fs/kernfs/file.c	2014-04-19 08:22:11.754042780 +0200
@@ -475,7 +468,10 @@
 		goto out_unlock;
 
 	ops = kernfs_ops(of->kn);
+	if (ops->mmap)
+		rc = ops->mmap(of, vma);
+	if (rc)
+		goto out_put;
-	rc = ops->mmap(of, vma);
 
 	/*
 	 * PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup()


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 555 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx