From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WbsWf-0003cR-FD for mharc-grub-devel@gnu.org; Sun, 20 Apr 2014 10:15:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbsWY-0003Ys-WF for grub-devel@gnu.org; Sun, 20 Apr 2014 10:15:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WbsWR-0007rf-UL for grub-devel@gnu.org; Sun, 20 Apr 2014 10:15:14 -0400 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:65282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbsWR-0007rL-O5 for grub-devel@gnu.org; Sun, 20 Apr 2014 10:15:07 -0400 Received: by mail-ee0-f51.google.com with SMTP id c13so3048290eek.10 for ; Sun, 20 Apr 2014 07:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=l4TipySy3Fx19fjRQFCDyFPtmydvuk5DslI0HE/6tEk=; b=PCnCXNk6pO/Bj8vXchGSJ+9YfDB0Y0LS9t9RlLPXwLKhbVrs2bOGzX3u1GKpPqifPc aIiouf1824bHHiMBHE7XLG2F42zqIWXWD7Bd8Y01IV+HFHlaFyM6WtYdBJEIWNO1mgoT 1VppP1FmKUWfvRpRfQjw05RHR1CLm0cIFvveV95pc4X0ojtPy9O222551hbN9zME2tDK MCuJEKg6OPeLSdEa5UyF4bHth0dvRBa5n2h9Q0VZ7vb5dV/j+f3NxpS7H9LDjfe7OYiu XRKypZJYOwOGEoGGB+Ltt3nxXhSMMR+cyh8mmZ2bDhPC+9BYbF/pBWWCXW8tCItI9QAn TC1g== X-Received: by 10.14.194.70 with SMTP id l46mr88759een.95.1398003306853; Sun, 20 Apr 2014 07:15:06 -0700 (PDT) Received: from [192.168.42.163] (1-228.197-178.cust.bluewin.ch. [178.197.228.1]) by mx.google.com with ESMTPSA id w1sm94948733eel.16.2014.04.20.07.15.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 20 Apr 2014 07:15:05 -0700 (PDT) Message-ID: <5353D667.5040600@gmail.com> Date: Sun, 20 Apr 2014 16:15:03 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: RFC Remove classful causing incorrect routing behavior References: <6D165E863E048E4D86C25F15CEA5329797665E90@ORSMSX109.amr.corp.intel.com> In-Reply-To: <6D165E863E048E4D86C25F15CEA5329797665E90@ORSMSX109.amr.corp.intel.com> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WJ4qWnWVwWuMop1wqoivuGXMDwTB83AA3" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2014 14:15:20 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WJ4qWnWVwWuMop1wqoivuGXMDwTB83AA3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 19.04.2014 02:48, Mroczek, Joseph T wrote: > Hello: >=20 > Currently, the DHCP logic assumes that if a gateway is received in the = DHCP packet the boot server is on a remote network. Given that CIDR is no= w over 20 years old, I think it is a safe assumption that a netmask will = be offered in DHCP options.=20 >=20 > Can this be removed? Or is there still a need to cover the classful cas= e? >=20 Please detail the failure scenario. Current code follows standard behaviour for PXE clients and changing it would break any installation which relies on it. > Thank you for any attention you can pay this matter. >=20 > ~joe >=20 >=20 > diff -Naur grub-2.02~beta2/grub-core/net/bootp.c grub-2.02~beta2-jtm-cl= ean/grub-core/net/bootp.c > --- grub-2.02~beta2/grub-core/net/bootp.c 2013-12-24 11:40:31.000000000= -0500 > +++ grub-2.02~beta2-jtm-clean/grub-core/net/bootp.c 2014-04-18 20:38:05= =2E858208600 -0400 > @@ -191,18 +227,6 @@ > if (bp->gateway_ip) > { > grub_net_network_level_netaddress_t target; > - grub_net_network_level_address_t gw; > - char *rname; > - =20 > - target.type =3D GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4; > - target.ipv4.base =3D bp->server_ip; > - target.ipv4.masksize =3D 32; > - gw.type =3D GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4; > - gw.ipv4 =3D bp->gateway_ip; > - rname =3D grub_xasprintf ("%s:gw", name); > - if (rname) > - grub_net_add_route_gw (rname, target, gw); > - grub_free (rname); > =20 > target.type =3D GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4; > target.ipv4.base =3D bp->gateway_ip; >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --WJ4qWnWVwWuMop1wqoivuGXMDwTB83AA3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlNT1mcACgkQmBXlbbo5nOsG2AD8DZq5NmHtUbto0ksA6LzN11SE j8TuQPuNUInGQKC0ty8A/ipTgOahyPmFJeIE+Ta5oskaAE5WF2CZ9tll/BJ9Bw+h =J9SN -----END PGP SIGNATURE----- --WJ4qWnWVwWuMop1wqoivuGXMDwTB83AA3--