From: Lan Tianyu <tianyu.lan@intel.com>
To: Pavel Machek <pavel@ucw.cz>, Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Stefan Lippers-Hollmann <s.L-H@gmx.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 3.14-rc: /proc/acpi/battery gone?
Date: Mon, 21 Apr 2014 19:29:10 +0800 [thread overview]
Message-ID: <53550106.8080907@intel.com> (raw)
In-Reply-To: <20140420130930.GD12135@amd.pavel.ucw.cz>
On 04/20/2014 09:09 PM, Pavel Machek wrote:
> Hi!
>
>>>> I just glance wmbattery code. I find the code in the acpi.c is already
>>>> using the new sysfs battery interfaces, right?
>>>
>>> By default, wmbattery appears to default to using upower as abstraction
>>> level, instead of querying sysfs itself directly.
>>>
>>> http://git.kitenet.net/?p=wmbattery.git;a=blob;f=autoconf/makeinfo.in;hb=HEAD
>>>
>>> which sets USE_UPOWER=1 by default.
>>>
>>> If USE_UPOWER=0 is set explicitly for the build, it reverts back to
>>> direct sysfs parsing - and yes, it does appear to adhere to the current
>>> sysfs API properly.
>>>
>>> The last remains, and the ability to parse procfs (which hasn't been
>>> default for quite some time already, in favour of using hal as
>>> abstraction layer) has finally been removed in
>>>
>>> http://git.kitenet.net/?p=wmbattery.git;a=commitdiff;h=833eb63a5ce4f2fb712a201b1db4f2db1700fddb
>>>
>>> The switch from procfs parsing to hal (by default at least) in turn
>>> happened with
>>>
>>> http://git.kitenet.net/?p=wmbattery.git;a=commitdiff;h=63c3d1a0b11e8ade1a5612bb5baa3d92e153bbbe
>>>
>>> in 2008 (before Debian squeeze/ oldstable). I have not investigated if
>>> hal then read from procfs or sysfs, but wmbattery at least didn't read
>>> from procfs itself, unless explicitly told to do so (USE_HAL=0) during
>>> the build since mid 2008.
>>>
>>> The current version of wmbattery however will never try to access
>>> /proc/acpi, the current version no longer knows of its existence.
>>>
>>> [Again, I'm not familiar with wmbattery myself and have never run it]
>>
>> Stefan,
>>
>> Thanks for looking into this. The newest wmbattery version indeed
>> supports upower. However, I haven't figured out how to get it to work.
>> That's obviously not the kernel's fault, but an unfortunate reality.
>> It seems to really want dbus to be running, but when I start dbus
>> (which nothing else on my system needs, apparently), it just hangs. My
>> knowledge of these things is, (un)fortunately non-existent, so I just
>> gave up on the upower approach. Running something as heavy as dbus
>> just for a silly dock app seems... silly as well.
>
> Any news on this one?
>
> It seems that delaying fsck on battery power also relies on
> /proc/acpi/battery...
Ok. I will prepare a patch to recover /proc/acpi/battery.
>
> https://bbs.archlinux.org/viewtopic.php?id=12168
>
> Pavel
>
next prev parent reply other threads:[~2014-04-21 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 21:14 3.14-rc: /proc/acpi/battery gone? Pavel Machek
2014-03-14 21:20 ` Pavel Machek
2014-03-14 21:29 ` Ilia Mirkin
2014-03-14 21:45 ` Richard Weinberger
2014-03-15 15:10 ` Lan Tianyu
2014-03-14 22:11 ` Pavel Machek
2014-03-14 22:14 ` Ilia Mirkin
2014-03-15 1:46 ` Rafael J. Wysocki
2014-03-15 2:17 ` Stefan Lippers-Hollmann
2014-03-15 15:29 ` Lan Tianyu
2014-03-15 16:05 ` Pavel Machek
2014-03-15 17:27 ` Lan Tianyu
2014-03-16 11:12 ` Pavel Machek
2014-03-16 3:57 ` Stefan Lippers-Hollmann
2014-03-17 17:28 ` Ilia Mirkin
2014-04-20 13:09 ` Pavel Machek
2014-04-21 11:29 ` Lan Tianyu [this message]
2014-03-15 14:08 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53550106.8080907@intel.com \
--to=tianyu.lan@intel.com \
--cc=imirkin@alum.mit.edu \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=s.L-H@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.