Re: [PATCH v3 12/18] xen/arm: IRQ: Do not allow IRQ to be shared between domains and XEN

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 08/04/14 15:44, Julien Grall wrote:
    > +    /* If the IRQ is already used by someone
> +     *  - If it's the same domain -> Xen doesn't need to update the IRQ desc
> +     *  - Otherwise -> For now, don't allow the IRQ to be shared between
> +     *  Xen and domains.
> +     */
> +    if ( desc->action != NULL )
> +    {
> +        struct domain *ad = irq_get_domain(desc);
> +
> +        if ( (desc->status & IRQ_GUEST) && d == ad )
> +            goto out;
> +
> +        if ( desc->status & IRQ_GUEST )
> +            printk(XENLOG_ERR "ERROR: IRQ %u is already used by domain %u\n",
> +                   irq->irq, ad->domain_id);
> +        else
> +            printk(XENLOG_ERR "ERROR: IRQ %u is already used by Xen\n",
> +                   irq->irq);
> +        retval = -EBUSY;
> +        goto out;

This code is buggy, I forgot to free the action in this case. I will fix 
it in the next version.

Ian: As said in the cover letter, I will only resend a V4 with all 
patches from this one (i.e #12 and onwards) as the other are already acked.

Let me know if I need to resend #1-#11.

Regards,

-- 
Julien Grall