From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>, kvm@vger.kernel.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs
Date: Mon, 21 Apr 2014 23:29:38 -0400 [thread overview]
Message-ID: <5355E222.7010607@redhat.com> (raw)
In-Reply-To: <jpgk3aiv6a9.fsf@nelium.bos.redhat.com>
Il 21/04/2014 15:20, Bandan Das ha scritto:
> + for (i = j = 0; i < max_shadow_read_write_fields; i++) {
> +
Extra empty line. Not a big deal, but...
> + switch (shadow_read_write_fields[i]) {
> + case GUEST_BNDCFGS:
> + if (!vmx_mpx_supported())
> + continue;
> + break;
> + default:
> + break;
> + }
> +
> + if (j < i)
> + shadow_read_write_fields[j] =
> + shadow_read_write_fields[i];
> + j++;
... you need to respin anyway because the j++ is wrong. It should be
inside the "if". If you prefer, you can put it in the lhs of the
assignment, otherwise a separate statement is fine by me too.
Paolo
next prev parent reply other threads:[~2014-04-22 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 19:20 [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs Bandan Das
2014-04-22 3:29 ` Paolo Bonzini [this message]
2014-04-22 16:25 ` Bandan Das
2014-04-22 19:13 ` Paolo Bonzini
2014-04-22 19:31 ` Bandan Das
2014-04-26 9:42 ` Paolo Bonzini
2014-04-28 9:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5355E222.7010607@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.