From: Robert Baldyga <r.baldyga-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org,
jonghwa3.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
rongjun.ying-kQvG35nSl+M@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API
Date: Tue, 22 Apr 2014 08:21:35 +0200 [thread overview]
Message-ID: <53560A6F.8030909@samsung.com> (raw)
In-Reply-To: <20140419105225.GB976-xqjnvvOjuzxi8rthE/p55WsfGuYhQEVp@public.gmane.org>
On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
> Hi,
>
> On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
>> dev_info(&pdev->dev,
>> - "OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n",
>> - (rev >> 4) & 0xf, rev & 0xf, config->extcon, otg_dev->id,
>> + "OMAP USB OTG controller rev %d.%d (id=%d, vbus=%d)\n",
>> + (rev >> 4) & 0xf, rev & 0xf, otg_dev->id,
>> otg_dev->vbus);
>
> This change is unrelated to the patch and not needed.
>
It's related because we no longer use config->extcon since we have
cable-oriented API. We can keep displaying it, but this value is
actually meaningless.
Best regards
Robert Baldyga
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Robert Baldyga <r.baldyga@samsung.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, myungjoo.ham@samsung.com, cw00.choi@samsung.com,
dbaryshkov@gmail.com, dwmw2@infradead.org, balbi@ti.com,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
ldewangan@nvidia.com, kishon@ti.com, gg@slimlogic.co.uk,
anton@enomsg.org, jonghwa3.lee@samsung.com, rongjun.ying@csr.com,
linux@roeck-us.net, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, m.szyprowski@samsung.com,
t.figa@samsung.com
Subject: Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API
Date: Tue, 22 Apr 2014 08:21:35 +0200 [thread overview]
Message-ID: <53560A6F.8030909@samsung.com> (raw)
In-Reply-To: <20140419105225.GB976@ambient.musicnaut.iki.fi>
On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
> Hi,
>
> On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
>> dev_info(&pdev->dev,
>> - "OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n",
>> - (rev >> 4) & 0xf, rev & 0xf, config->extcon, otg_dev->id,
>> + "OMAP USB OTG controller rev %d.%d (id=%d, vbus=%d)\n",
>> + (rev >> 4) & 0xf, rev & 0xf, otg_dev->id,
>> otg_dev->vbus);
>
> This change is unrelated to the patch and not needed.
>
It's related because we no longer use config->extcon since we have
cable-oriented API. We can keep displaying it, but this value is
actually meaningless.
Best regards
Robert Baldyga
Samsung R&D Institute Poland
next prev parent reply other threads:[~2014-04-22 6:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 11:46 [PATCH v2 00/13] extcon: major rework Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 01/13] Documentation: add extcon devicetree bindings Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-22 19:51 ` Mark Brown
2014-04-22 19:51 ` Mark Brown
2014-04-25 13:19 ` Robert Baldyga
2014-04-25 14:11 ` Mark Brown
2014-04-14 11:46 ` [PATCH v2 02/13] Documentation: update charger-manager " Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 03/13] extcon: extcon-class: remove extcon_set_cable_state() function Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 04/13] extcon: extcon-class: match extcon device by devicetree node Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 05/13] extcon: extcon-class: improve extcon client API Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-19 10:52 ` Aaro Koskinen
[not found] ` <20140419105225.GB976-xqjnvvOjuzxi8rthE/p55WsfGuYhQEVp@public.gmane.org>
2014-04-22 6:21 ` Robert Baldyga [this message]
2014-04-22 6:21 ` Robert Baldyga
2014-04-22 14:51 ` Felipe Balbi
2014-04-22 14:51 ` Felipe Balbi
2014-04-22 15:03 ` Aaro Koskinen
2014-04-23 7:33 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 06/13] extcon: extcon-class: remove unused functions Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 07/13] extcon: extcon-class: improve get_cable_state_()/set_cable_state_() functions Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
[not found] ` <1397475984-28001-1-git-send-email-r.baldyga-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-04-14 11:46 ` [PATCH v2 08/13] extcon: extcon-class: simplify extcon_updata_state() function Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 10/13] extcon: extcon-gpio: add devicetree support Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-23 20:00 ` [PATCH v2 00/13] extcon: major rework Aaro Koskinen
2014-04-23 20:00 ` Aaro Koskinen
2014-04-14 11:46 ` [PATCH v2 09/13] extcon: extcon-class: move example to Documentation Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 11/13] extcon: extcon-adc-jack: add devicetree support Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 12/13] extcon: extcon-max8997: check if pdata exists Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-14 11:46 ` [PATCH v2 13/13] extcon: extcon-max77693: " Robert Baldyga
2014-04-14 11:46 ` Robert Baldyga
2014-04-24 19:52 ` [PATCH v2 00/13] extcon: major rework Greg KH
2014-04-28 9:34 ` Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53560A6F.8030909@samsung.com \
--to=r.baldyga-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jonghwa3.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rongjun.ying-kQvG35nSl+M@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.