From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Christian_K=F6nig?= Subject: Re: [PATCH] drm/radeon/aux: fix hpd assignment for aux bus Date: Tue, 22 Apr 2014 11:17:06 +0200 Message-ID: <53563392.6090003@vodafone.de> References: <1398146526-9227-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 1484C6E6E4 for ; Tue, 22 Apr 2014 02:17:20 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix2 Daemon) with ESMTP id 2B23F543B22 for ; Tue, 22 Apr 2014 11:17:19 +0200 (CEST) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix2.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nYZvrsrMGXpo for ; Tue, 22 Apr 2014 11:17:13 +0200 (CEST) In-Reply-To: <1398146526-9227-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , dri-devel@lists.freedesktop.org Cc: Alex Deucher List-Id: dri-devel@lists.freedesktop.org Am 22.04.2014 08:02, schrieb Alex Deucher: > The hpd (hot plug detect) pin assignment got lost > in the conversion to to the common i2c over aux > code. Without this information, aux transactions > do not work properly. Fixes DP failures. > > Signed-off-by: Alex Deucher Added to my 3.15 queue. Does this also fix the issue Ed Tomlinson reported about? Christian. > --- > drivers/gpu/drm/radeon/atombios_dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c > index 1593652..bc0119f 100644 > --- a/drivers/gpu/drm/radeon/atombios_dp.c > +++ b/drivers/gpu/drm/radeon/atombios_dp.c > @@ -209,6 +209,7 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector) > { > int ret; > > + radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd; > radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev; > radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer; > ret = drm_dp_aux_register_i2c_bus(&radeon_connector->ddc_bus->aux);