From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] x86/HAP: drop pointless assertions
Date: Tue, 22 Apr 2014 13:32:16 +0100 [thread overview]
Message-ID: <53566150.5050704@citrix.com> (raw)
In-Reply-To: <53566EF9020000780000AB5A@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]
On 22/04/14 12:30, Jan Beulich wrote:
> Just like for shadow code, hap_map_domain_page() is just a thin
> wrapper around map_domain_page(), which cannot fail. Asserting its
> success is redundant.
>
> hap_unmap_domain_page() should also not be used for something not
> mapped through hap_map_domain_page().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/mm/hap/hap.c
> +++ b/xen/arch/x86/mm/hap/hap.c
> @@ -233,9 +233,8 @@ static struct page_info *hap_alloc(struc
> d->arch.paging.hap.free_pages--;
>
> p = __map_domain_page(pg);
> - ASSERT(p != NULL);
> clear_page(p);
> - hap_unmap_domain_page(p);
> + unmap_domain_page(p);
>
> return pg;
> }
> @@ -375,7 +374,6 @@ static void hap_install_xen_entries_in_l
> l4_pgentry_t *l4e;
>
> l4e = hap_map_domain_page(l4mfn);
> - ASSERT(l4e != NULL);
>
> /* Copy the common Xen mappings from the idle domain */
> memcpy(&l4e[ROOT_PAGETABLE_FIRST_XEN_SLOT],
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2060 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-04-22 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:30 [PATCH] x86/HAP: drop pointless assertions Jan Beulich
2014-04-22 12:32 ` Andrew Cooper [this message]
2014-04-24 11:47 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53566150.5050704@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.