From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v8 1/3] xen/libxc: Allow changing max number
 of hypervisor cpuid leaves
Date: Tue, 22 Apr 2014 08:32:25 -0400
Message-ID: <53566159.2090105@oracle.com>
References: <1398117433-6428-1-git-send-email-boris.ostrovsky@oracle.com>
	<1398117433-6428-2-git-send-email-boris.ostrovsky@oracle.com>
	<53565673020000780000AA82@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53565673020000780000AA82@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 04/22/2014 05:45 AM, Jan Beulich wrote:
>>>> On 21.04.14 at 23:57, <boris.ostrovsky@oracle.com> wrote:
>> +    if ( (limit < 2) || (limit > XEN_CPUID_MAX_NUM_LEAVES) )
>> +        limit = XEN_CPUID_MAX_NUM_LEAVES;
> Almost: If limit < 2, you would be better off using 2 rather than the
> default (which may be growing).

My thinking was that for any invalid limit value we should ignore what 
the user file specified, not try to guess what was meant.

-boris