From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix Q_XQUOTARM ioctl
Date: Tue, 22 Apr 2014 10:54:11 -0500 [thread overview]
Message-ID: <535690A3.3080609@redhat.com> (raw)
In-Reply-To: <20140422064316.GA30375@infradead.org>
On 4/22/14, 1:43 AM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 03:33:37PM -0500, Eric Sandeen wrote:
>> The Q_XQUOTARM quotactl was not working properly, because
>> we weren't passing around proper flags. The xfs_fs_set_xstate()
>> ioctl handler used the same flags for Q_XQUOTAON/OFF as
>> well as for Q_XQUOTARM, but Q_XQUOTAON/OFF look for
>> XFS_UQUOTA_ACCT, XFS_UQUOTA_ENFD, XFS_GQUOTA_ACCT etc,
>> i.e. quota type + state, while Q_XQUOTARM looks only for
>> the type of quota, i.e. XFS_DQ_USER, XFS_DQ_GROUP etc.
>>
>> Unfortunately these flag spaces overlap a bit, so we
>> got semi-random results for Q_XQUOTARM; i.e. the value
>> for XFS_DQ_USER == XFS_UQUOTA_ACCT, etc. yeargh.
>>
>> Split out the flag conversion from userspace to kernelspace,
>> depending on the quotactl that is being executed; add 2 new
>> helpers to do this, so that we send the right flags to the
>> lower-level functions.
>>
>> This has been broken more or less forever, AFAICT.
>
> So if this isn't very urgent I'd rather replace ->set_xstate with one
> operation per ioctl, so that we don't multiple different kinds of flags
> over the same operation.
>
eh, that's probably better, I'll take a look.
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-22 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:33 [PATCH] xfs: fix Q_XQUOTARM ioctl Eric Sandeen
2014-04-22 6:43 ` Christoph Hellwig
2014-04-22 15:54 ` Eric Sandeen [this message]
2014-04-22 18:48 ` [PATCH V2] " Eric Sandeen
2014-04-22 21:30 ` Dave Chinner
2014-04-22 21:48 ` Jan Kara
2014-04-23 15:27 ` Christoph Hellwig
2014-04-23 15:28 ` Eric Sandeen
2014-04-23 15:39 ` Christoph Hellwig
2014-05-03 11:48 ` [PATCH] " Christoph Hellwig
2014-05-03 14:36 ` Eric Sandeen
2014-05-03 15:14 ` Christoph Hellwig
2014-05-04 0:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535690A3.3080609@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.