All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()
Date: Tue, 22 Apr 2014 10:56:19 -0500	[thread overview]
Message-ID: <53569123.2080807@sandeen.net> (raw)
In-Reply-To: <535663CB.5080309@oracle.com>

On 4/22/14, 7:42 AM, Jeff Liu wrote:
> 
> On 04/22 2014 14:27 PM, Christoph Hellwig wrote:
>> On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote:
>>> Coverity noticed that if we sent junk into
>>> xfs_qm_scall_trunc_qfiles(), we could get back an
>>> uninitialized error value.  So sanitize the flags we
>>> will accept, and initialize error anyway for good measure.
>>>
>>> (This bug may have been introduced via c61a9e39).
> 
> Indeed, my mistake.

No worries, it's a very small thing, and programatically
impossible.  Not trying to point fingers, just looking for
whether it's a new warning or an old one.

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2014-04-22 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 20:45 [PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles() Eric Sandeen
2014-04-22  6:27 ` Christoph Hellwig
2014-04-22 12:42   ` Jeff Liu
2014-04-22 15:56     ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53569123.2080807@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=jeff.liu@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.