From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine option) Date: Tue, 22 Apr 2014 12:31:16 -0400 Message-ID: <53569954.9040807@terremark.com> References: <1395705336-22528-1-git-send-email-dslutz@verizon.com> <20140325090807.GA23693@redhat.com> <5351324E.9090603@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <5351324E.9090603@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: =?ISO-8859-1?Q?Andreas_F=E4rber?= , "Michael S. Tsirkin" , Don Slutz Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, Anthony Liguori , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/18/14 10:10, Andreas Färber wrote: > Am 25.03.2014 10:08, schrieb Michael S. Tsirkin: >> On Mon, Mar 24, 2014 at 07:55:32PM -0400, Don Slutz wrote: >>> Changes v2 to v3: >>> Stefano Stabellini: >>> Acked-by #1 "xen-all: Fix xen_hvm_init() to adjust pc memory" >>> Adjust for code readability #4 "xen-all: Pass max_ram_below_4g to xen_hvm_init." >>> Set max_ram_below_4g always and use it to calculate above_4g_mem_size, >>> below_4g_mem_size. >>> >>> Changes v1 to v2: >>> Michael S. Tsirkin: >>> Rename option. >>> Only add it to machine types that support it. >>> Split into 4 parts. >>> >>> 1/4 -- xen-all: Fix xen_hvm_init() to adjust pc memory layout >>> >>> This looks to be a possible bug that has yet to be found. >>> below_4g_mem_size and above_4g_mem_size are stored in PcGuestInfo >>> (pc_guest_info_init) which are currently not "correct". This and >>> 4/4 change the same lines. >>> >>> 2/4 -- GlobalProperty: Display warning about unused -global >>> >>> My testing showed that setting a global property on an object >>> that is not used is not reported at all. This is added to help >>> when the new global is set but not used. The negative not_used >>> was picked so that all static objects are assumed to be used >>> even when they are not. >>> >>> 3/4 -- pc & q35: Add new object pc-memory-layout >>> >>> The objects that it might make sense to add this property to all >>> get created too late. So add a new object just to hold this >>> property. Name it so that it is expected that only pc (and q35) >>> machine types support it. >>> >>> 4/4 -- xen-all: Pass max_ram_below_4g to xen_hvm_init >>> >>> Seprate the xen only part of the change. Currectly based on patch 1/4 >>> >>> Don Slutz (4): >>> xen-all: Fix xen_hvm_init() to adjust pc memory layout. >>> GlobalProperty: Display warning about unused -global >>> pc & q35: Add new object pc-memory-layout. >>> xen-all: Pass max_ram_below_4g to xen_hvm_init. >>> >>> hw/core/qdev-properties-system.c | 1 + >>> hw/core/qdev-properties.c | 15 ++++++++++++ >>> hw/i386/pc.c | 42 ++++++++++++++++++++++++++++++++ >>> hw/i386/pc_piix.c | 52 +++++++++++++++++++++++++++------------- >>> hw/i386/pc_q35.c | 50 ++++++++++++++++++++++++++------------ >>> include/hw/i386/pc.h | 2 ++ >>> include/hw/qdev-core.h | 1 + >>> include/hw/qdev-properties.h | 1 + >>> include/hw/xen/xen.h | 3 ++- >>> vl.c | 2 ++ >>> xen-all.c | 46 +++++++++++++++++++---------------- >>> xen-stub.c | 3 ++- >>> 12 files changed, 165 insertions(+), 53 deletions(-) >> Andreas, could you review pls, esp patch 2? > Michael, I don't see a dependency of the later patches on 2/4, so I'd > like to split that one out of this series and reiterate. I am happy to split out 2/4. > I'll have some minor comments on the rest. > > Don, in general please do not end subjects with a dot. Ok, will attempt to do so. -Don Slutz > CC'ing Eduardo and Igor who looked into 4G issues previously. > > Regards, > Andreas >