All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gerlach <d-gerlach@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	Nishanth Menon <nm@ti.com>,
	bcousson@baylibre.com, Sekhar Nori <nsekhar@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH] ARM: dts: am437x-gp-evm: Boot fixes
Date: Tue, 22 Apr 2014 14:53:18 -0500	[thread overview]
Message-ID: <5356C8AE.3090907@ti.com> (raw)
In-Reply-To: <20140422190132.GA12204@atomide.com>

On 04/22/2014 02:01 PM, Tony Lindgren wrote:
> * Dave Gerlach <d-gerlach@ti.com> [140422 11:52]:
>> This patch, along with patch here [1], fixes boot for am437x-gp-evm. The
>> bootloader configures gpio5_7 to control the DDR3 termination regulator,
>> the linked patch prevents that gpio bank from being reset and losing
>> the previously configured state, and this patch binds the gpio to a
>> regulator so the kernel is aware of the state of the gpio.
>>
>> [1] https://www.mail-archive.com/linux-omap@vger.kernel.org/msg102941.html
>
> Setting up the GPIO regulator makes sense to me. But the hack in the
> link above is potentially a nasty time bomb for anybody trying to
> use GPIO bank 5 on that board.
>
> What tests have been done that the GPIO bank behaves properly when
> it's not reset?

We've been using this configuration on this board for a while without 
any apparent issues. Also, am335x-evmsk already uses the same idea for 
the VTT regulator on board from commit 
6046adb6ad701026c10adeac8d6a4138895f12e5 [ARM: dts: am335x-evmsk: Do not 
reset gpio0] and I am unaware of any issues with that either.

Regards,
Dave

>
> Regards,
>
> Tony
>


WARNING: multiple messages have this Message-ID (diff)
From: d-gerlach@ti.com (Dave Gerlach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am437x-gp-evm: Boot fixes
Date: Tue, 22 Apr 2014 14:53:18 -0500	[thread overview]
Message-ID: <5356C8AE.3090907@ti.com> (raw)
In-Reply-To: <20140422190132.GA12204@atomide.com>

On 04/22/2014 02:01 PM, Tony Lindgren wrote:
> * Dave Gerlach <d-gerlach@ti.com> [140422 11:52]:
>> This patch, along with patch here [1], fixes boot for am437x-gp-evm. The
>> bootloader configures gpio5_7 to control the DDR3 termination regulator,
>> the linked patch prevents that gpio bank from being reset and losing
>> the previously configured state, and this patch binds the gpio to a
>> regulator so the kernel is aware of the state of the gpio.
>>
>> [1] https://www.mail-archive.com/linux-omap at vger.kernel.org/msg102941.html
>
> Setting up the GPIO regulator makes sense to me. But the hack in the
> link above is potentially a nasty time bomb for anybody trying to
> use GPIO bank 5 on that board.
>
> What tests have been done that the GPIO bank behaves properly when
> it's not reset?

We've been using this configuration on this board for a while without 
any apparent issues. Also, am335x-evmsk already uses the same idea for 
the VTT regulator on board from commit 
6046adb6ad701026c10adeac8d6a4138895f12e5 [ARM: dts: am335x-evmsk: Do not 
reset gpio0] and I am unaware of any issues with that either.

Regards,
Dave

>
> Regards,
>
> Tony
>

  reply	other threads:[~2014-04-22 19:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 18:52 [PATCH] ARM: dts: am437x-gp-evm: Boot fixes Dave Gerlach
2014-04-22 18:52 ` Dave Gerlach
2014-04-22 18:52 ` [PATCH] ARM: dts: am437x-gp-evm: Add vtt_fixed regulator Dave Gerlach
2014-04-22 18:52   ` Dave Gerlach
2014-04-22 18:58   ` Nishanth Menon
2014-04-22 18:58     ` Nishanth Menon
2014-04-22 19:53     ` Dave Gerlach
2014-04-22 19:53       ` Dave Gerlach
2014-04-22 19:01 ` [PATCH] ARM: dts: am437x-gp-evm: Boot fixes Tony Lindgren
2014-04-22 19:01   ` Tony Lindgren
2014-04-22 19:53   ` Dave Gerlach [this message]
2014-04-22 19:53     ` Dave Gerlach
2014-04-23 14:59     ` Tony Lindgren
2014-04-23 14:59       ` Tony Lindgren
2014-04-23 17:25       ` Dave Gerlach
2014-04-23 17:25         ` Dave Gerlach
2014-04-25 16:41         ` Tony Lindgren
2014-04-25 16:41           ` Tony Lindgren
2014-04-29 14:47           ` Dave Gerlach
2014-04-29 14:47             ` Dave Gerlach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5356C8AE.3090907@ti.com \
    --to=d-gerlach@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.