From: Daniel Borkmann <dborkman@redhat.com>
To: Chema Gonzalez <chema@google.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@plumgrid.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] filter: added BPF random opcode
Date: Tue, 22 Apr 2014 23:10:44 +0200 [thread overview]
Message-ID: <5356DAD4.8090100@redhat.com> (raw)
In-Reply-To: <1398097284-20528-1-git-send-email-chema@google.com>
On 04/21/2014 06:21 PM, Chema Gonzalez wrote:
> Added a new ancillary load (bpf call in eBPF parlance) that produces
> a 32-bit random number. We are implementing it as an ancillary load
> (instead of an ISA opcode) because (a) it is simpler, (b) allows easy
> JITing, and (c) seems more in line with generic ISAs that do not have
> "get a random number" as a instruction, but as an OS call.
>
> The main use for this ancillary load is to perform random packet sampling.
>
> Signed-off-by: Chema Gonzalez <chema@google.com>
Generally, I'm fine with your patch. If some day other use cases pop up
in non-packet filtering areas, we might need to let it return a 64 bit
number, but lets see. Thanks again for updating bpf_asm as well!
Acked-by: Daniel Borkmann <dborkman@redhat.com>
next prev parent reply other threads:[~2014-04-22 21:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 18:16 [PATCH] filter: added BPF random opcode Chema Gonzalez
2014-04-16 6:24 ` Alexei Starovoitov
2014-04-16 8:32 ` Daniel Borkmann
2014-04-17 0:19 ` Chema Gonzalez
2014-04-17 1:38 ` Eric Dumazet
2014-04-18 20:21 ` Alexei Starovoitov
2014-04-21 16:21 ` [PATCH v2] " Chema Gonzalez
2014-04-21 21:46 ` Alexei Starovoitov
2014-04-21 21:54 ` Chema Gonzalez
2014-04-21 22:20 ` Alexei Starovoitov
2014-04-21 23:19 ` Chema Gonzalez
2014-04-22 2:42 ` Alexei Starovoitov
2014-04-22 21:10 ` Daniel Borkmann [this message]
2014-04-23 1:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356DAD4.8090100@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=chema@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.